feat/GameApplication by ManhTanTran · Pull Request #8 · CodeStormOOP/bounceverse

ManhTanTran · 2025-10-05T10:20:58Z

🎮 Summary

Introduced the core game management system and the main FXGL application entry point.
This update lays the foundation for gameplay initialization, brick spawning, and runtime management.

✨ Changes

Added GameManager class to handle:
- Brick spawning via BrickFactory
- Score updates based on brick destruction
- Power-up tracking and management
- Level and lives handling logic
Added BounceVerseApp:
- Configures FXGL game window, title, and resolution
- Sets up scene background and initial game entities

…dBrick

…tedBrick

…Paddle

…Protected, Explode)

Copilot

Pull Request Overview

This PR introduces the core game management system and main application entry point for BounceVerse, a breakout-style game built with FXGL. The update establishes the foundational architecture for brick-based gameplay with various brick types and power-up mechanics.

Added GameManager class for handling game logic including brick spawning, score management, and level progression
Implemented comprehensive brick system with multiple types (normal, strong, explode, protected) and factory pattern
Created paddle hierarchy with specialized variants (laser, shrink, expand) and main FXGL application setup

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
BounceVerseApp.java	Main FXGL application entry point with game window configuration and initialization
GameManager.java	Core game logic manager handling brick spawning, scoring, and game state
BrickFactory.java	Factory class for creating different brick entity types with visual components
BrickComponent.java	Base brick component with HP system, visual updates, and destruction logic
ExplodeBrick.java	Specialized brick that triggers explosion effects on nearby bricks when destroyed
ProtectedBrick.java	Brick variant with directional shields that block hits from specific sides
PowerBrick.java	Power-up brick component (placeholder implementation)
Paddle.java	Base paddle class with movement and positioning capabilities
LaserPaddle.java	Paddle variant capable of shooting bullets (placeholder bullet management)
ShrinkPaddle.java	Narrower paddle variant using scale factor
ExpendPaddle.java	Wider paddle variant using scale factor

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-05T10:21:54Z

src/main/java/com/github/codestorm/bounceverse/paddle/LaserPaddle.java

+ */
+public class LaserPaddle extends Paddle {
+    /** List of bullets currently fired by the paddle. */
+    private List<LaserPaddle> bullets;


The bullets list should contain bullet entities, not LaserPaddle instances. This should be List<Entity> or a dedicated bullet class type.

Copilot · 2025-10-05T10:21:54Z

src/main/java/com/github/codestorm/bounceverse/paddle/LaserPaddle.java

+    /** Updates all bullets when them get off-screen or hit the brick. */
+    public void updateBullets() {}
+
+    public List<LaserPaddle> getBullets() {


The return type should match the bullets field type. If bullets should be Entity objects, this should return List<Entity>.

Copilot · 2025-10-05T10:21:55Z

src/main/java/com/github/codestorm/bounceverse/paddle/ExpendPaddle.java

+    // The scale factor applied to the paddle's width.
+    private static final double SCALE = 1.5;
+
+    // Create a new expended paddle.


Comment should say 'expanded paddle' instead of 'expended paddle' to match the intended functionality.

Suggested change

// Create a new expended paddle.

// Create a new expanded paddle.

src/main/java/com/github/codestorm/bounceverse/BounceVerseApp.java

Copilot · 2025-10-05T10:21:55Z

src/main/java/com/github/codestorm/bounceverse/brick/BrickComponent.java

+
+    /** Create a rectangular visual for brick. */
+    public void onAdded() {
+        // Lấy view của Entity


Comment is in Vietnamese. Should be in English: '// Get the Entity's view'

Suggested change

// Lấy view của Entity

// Get the Entity's view

Copilot · 2025-10-05T10:21:55Z

src/main/java/com/github/codestorm/bounceverse/brick/ExplodeBrick.java

+        List<Entity> entites = FXGL.getGameWorld().getEntities();
+        for (Entity e : entites) {


Variable name 'entites' should be 'entities' (missing 'i').

Suggested change

List<Entity> entites = FXGL.getGameWorld().getEntities();

for (Entity e : entites) {

List<Entity> entities = FXGL.getGameWorld().getEntities();

for (Entity e : entities) {

# Conflicts: # src/main/java/com/github/codestorm/bounceverse/brick/PowerBrick.java # src/main/java/com/github/codestorm/bounceverse/brick/ProtectedBrick.java

- Renamed `BounceVerseApp` to `Bounceverse` for consistency. - Set the game title to the new class name. - Integrated `BrickFactory` for spawning bricks in the game. - Updated `build.gradle` for application configuration and added release tasks.

.github/workflows/build.yml

.github/workflows/buildRelease.yml

- Added permissions to `buildRelease.yml`, `build.yml`, and `setup.yml` (to manage content access). - Created new log files for debugging (to assist in troubleshooting). - Updated `Readme.txt` to clarify the purpose of the directory.

Copilot

Pull Request Overview

Copilot reviewed 14 out of 16 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

.idea/misc.xml: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-08T04:09:15Z

src/main/java/com/github/codestorm/bounceverse/Bounceverse.java

+        FXGL.getGameWorld().addEntityFactory(new BrickFactory());
+
+        var brick1 = FXGL.spawn("normalBrick", 100, 100);
+        var brick2 = FXGL.spawn("normalBrick", 100, 100);


Both bricks are spawned at the exact same position (100, 100), causing them to overlap. The second brick should be positioned differently.

Suggested change

var brick2 = FXGL.spawn("normalBrick", 100, 100);

var brick2 = FXGL.spawn("normalBrick", 150, 100);

Copilot · 2025-10-08T04:09:15Z

.github/workflows/linting.yml

+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: .github/workflows/setup.yml


Cannot use a workflow file as a step. Use 'uses: ./.github/workflows/setup.yml' for a reusable workflow or convert setup.yml to an action.

Suggested change

- uses: .github/workflows/setup.yml

- uses: ./.github/workflows/setup.yml

with: {}

secrets: {}

Copilot · 2025-10-08T04:09:16Z

.github/workflows/build.yml

+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: .github/workflows/setup.yml


Cannot use a workflow file as a step. Use 'uses: ./.github/workflows/setup.yml' for a reusable workflow or convert setup.yml to an action.

Suggested change

- uses: .github/workflows/setup.yml

- uses: ./.github/workflows/setup.yml

Copilot · 2025-10-08T04:09:16Z

.github/workflows/buildRelease.yml

+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: .github/workflows/setup.yml


Cannot use a workflow file as a step. Use 'uses: ./.github/workflows/setup.yml' for a reusable workflow or convert setup.yml to an action.

Suggested change

- uses: .github/workflows/setup.yml

- uses: ./.github/workflows/setup.yml@main

Expanded the guidelines for writing commit messages, detailing structure, types, and examples to ensure clarity and consistency in commit history.

thnhmai06

lgtm nhưng @ManhTanTran cần bám sát sườn vào các đối tượng trong engine nhé

* feat: Brick * feat(brick): add PowerBrick and update Brick, ExoplodeBrick, ProtectedBrick * docs(brick): add Javadoc for Brick, ExoplodeBrick, PowerBrick, ProtectedBrick * refactor(brick): remove NormalBrick and StrongBrick * feat(paddle): add ExpendPaddle, LaserPaddle, ShrinkPaddle and update Paddle * feat(paddle): add ExpendPaddle, LaserPaddle, ShrinkPaddle and update Paddle * refactor: remove brick and gameManager packages * feat(brick): refactor and document brick module (Factory, Component, Protected, Explode) * feat(game): add GameManager and BounceVerseApp for game initialization * refactor: Refactor GameManager, build/run scripts and update ci/cd - Renamed `BounceVerseApp` to `Bounceverse` for consistency. - Set the game title to the new class name. - Integrated `BrickFactory` for spawning bricks in the game. - Updated `build.gradle` for application configuration and added release tasks. * ci: add specific workflow permission - Added permissions to `buildRelease.yml`, `build.yml`, and `setup.yml` (to manage content access). - Created new log files for debugging (to assist in troubleshooting). - Updated `Readme.txt` to clarify the purpose of the directory. * docs: update git commit instructions to align with Conventional Commits Expanded the guidelines for writing commit messages, detailing structure, types, and examples to ensure clarity and consistency in commit history. --------- Co-authored-by: Mai Thành <62001770+thnhmai06@users.noreply.github.com>

ManhTanTran added 10 commits September 29, 2025 17:13

feat: Brick

6229cc2

feat(brick): add PowerBrick and update Brick, ExoplodeBrick, Protecte…

7418ab1

…dBrick

docs(brick): add Javadoc for Brick, ExoplodeBrick, PowerBrick, Protec…

b4f0622

…tedBrick

refactor(brick): remove NormalBrick and StrongBrick

89c507a

feat(paddle): add ExpendPaddle, LaserPaddle, ShrinkPaddle and update …

2453417

…Paddle

feat(paddle): add ExpendPaddle, LaserPaddle, ShrinkPaddle and update …

a493678

…Paddle

feat(paddle): add ExpendPaddle, LaserPaddle, ShrinkPaddle and update …

02e8c82

…Paddle

refactor: remove brick and gameManager packages

5e9ce2e

feat(brick): refactor and document brick module (Factory, Component, …

6af822f

…Protected, Explode)

feat(game): add GameManager and BounceVerseApp for game initialization

9391b00

Copilot AI review requested due to automatic review settings October 5, 2025 10:20

Copilot AI reviewed Oct 5, 2025

View reviewed changes

thnhmai06 added 2 commits October 8, 2025 02:49

Merge branch 'refs/heads/main' into feature/game-manager

acd5cf4

# Conflicts: # src/main/java/com/github/codestorm/bounceverse/brick/PowerBrick.java # src/main/java/com/github/codestorm/bounceverse/brick/ProtectedBrick.java

github-advanced-security bot found potential problems Oct 8, 2025

View reviewed changes

.github/workflows/build.yml Fixed Show fixed Hide fixed

.github/workflows/buildRelease.yml Fixed Show fixed Hide fixed

thnhmai06 changed the title ~~Feature/game manager~~ feat/GameApplication Oct 8, 2025

ci: add specific workflow permission

d5f360f

- Added permissions to `buildRelease.yml`, `build.yml`, and `setup.yml` (to manage content access). - Created new log files for debugging (to assist in troubleshooting). - Updated `Readme.txt` to clarify the purpose of the directory.

Copilot AI review requested due to automatic review settings October 8, 2025 04:08

Copilot AI reviewed Oct 8, 2025

View reviewed changes

docs: update git commit instructions to align with Conventional Commits

718f430

Expanded the guidelines for writing commit messages, detailing structure, types, and examples to ensure clarity and consistency in commit history.

thnhmai06 self-requested a review October 8, 2025 04:12

thnhmai06 approved these changes Oct 8, 2025

View reviewed changes

thnhmai06 merged commit f9ae3d2 into main Oct 8, 2025
4 checks passed

thnhmai06 deleted the feature/game-manager branch October 8, 2025 04:13

thnhmai06 mentioned this pull request Oct 8, 2025

✨ feat(brick): add BrickComponent and variants (Explode, Power, Protected) with BrickFactory #9

Closed

	// Create a new expended paddle.
	// Create a new expanded paddle.

		List<Entity> entites = FXGL.getGameWorld().getEntities();
		for (Entity e : entites) {

	var brick2 = FXGL.spawn("normalBrick", 100, 100);
	var brick2 = FXGL.spawn("normalBrick", 150, 100);

-      - uses: .github/workflows/setup.yml
+      - uses: ./.github/workflows/setup.yml
+        with: {}
+        secrets: {}

	- uses: .github/workflows/setup.yml
	- uses: ./.github/workflows/setup.yml

	- uses: .github/workflows/setup.yml
	- uses: ./.github/workflows/setup.yml@main

Comments

Conversation

ManhTanTran commented Oct 5, 2025

🎮 Summary

✨ Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

thnhmai06 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants