Brick by ManhTanTran · Pull Request #7 · CodeStormOOP/bounceverse

ManhTanTran · 2025-10-05T10:19:12Z

🧱 Summary

Refactored and improved the brick system to support multiple brick types, better visuals, and cleaner code structure.

✨ Changes

Added BrickFactory to centralize brick creation logic (Normal, Strong, Explode, Protected)
Implemented BrickComponent with HP-based color updates and dynamic visual feedback
Enhanced ProtectedBrick to display visible shields (top, bottom, left, right)
Improved ExplodeBrick with explosion damage handling
Cleaned up redundant base Brick class and replaced with component-based system

…dBrick

…tedBrick

…Paddle

…Protected, Explode)

Copilot

Pull Request Overview

Refactored the brick system to use a component-based architecture with centralized factory pattern, replacing inheritance-based brick classes with a more flexible component system that supports multiple brick types with enhanced visuals and cleaner code organization.

Replaced base Brick class with BrickComponent using component-based architecture
Added BrickFactory for centralized creation of different brick types (Normal, Strong, Explode, Protected)
Enhanced brick visuals with HP-based color updates and shield rendering for protected bricks

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/main/java/com/github/codestorm/bounceverse/paddle/ShrinkPaddle.java	New paddle subclass that scales width by 0.7 factor
src/main/java/com/github/codestorm/bounceverse/paddle/Paddle.java	Base paddle class with position, movement, and reset functionality
src/main/java/com/github/codestorm/bounceverse/paddle/LaserPaddle.java	Paddle subclass with bullet shooting capabilities
src/main/java/com/github/codestorm/bounceverse/paddle/ExpendPaddle.java	Paddle subclass that scales width by 1.5 factor
src/main/java/com/github/codestorm/bounceverse/brick/ProtectedBrick.java	Updated to extend BrickComponent with shield-based damage protection
src/main/java/com/github/codestorm/bounceverse/brick/PowerBrick.java	Updated to extend BrickComponent for power-up functionality
src/main/java/com/github/codestorm/bounceverse/brick/ExplodeBrick.java	New explosive brick that damages surrounding bricks when destroyed
src/main/java/com/github/codestorm/bounceverse/brick/BrickFactory.java	Factory class for creating different brick entity types with visual configurations
src/main/java/com/github/codestorm/bounceverse/brick/BrickComponent.java	Core component class managing brick HP, visuals, and destruction behavior

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-05T10:19:55Z

+        List<Entity> entites = FXGL.getGameWorld().getEntities();
+        for (Entity e : entites) {


Variable name 'entites' should be 'entities'.

Suggested change

List<Entity> entites = FXGL.getGameWorld().getEntities();

for (Entity e : entites) {

List<Entity> entities = FXGL.getGameWorld().getEntities();

for (Entity e : entities) {

thnhmai06 · 2025-10-07T11:39:13Z

+        this.initialHp = hp;
+        this.baseColor = baseColor;
+        this.destroyed = false;
+    }


destroyed already in health

- Added Brick, BrickHealth, BrickDrop, BrickExplode, and BrickFactory classes to manage brick entities and their behaviors (enhances gameplay mechanics). - Refactored existing classes to align with new component structure.

Copilot

Pull Request Overview

Copilot reviewed 24 out of 25 changed files in this pull request and generated 5 comments.

Files not reviewed (1)

.idea/misc.xml: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 24 out of 25 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

.idea/misc.xml: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Removed the @spawns annotation from the newBrick methods in BrickFactory to streamline the code and eliminate unnecessary complexity (no functional changes).

# Conflicts: # .idea/misc.xml

Copilot

Pull Request Overview

Copilot reviewed 24 out of 25 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

.idea/misc.xml: Language not supported

Comments suppressed due to low confidence (1)

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-07T19:41:32Z

+    // The scale factor applied to the paddle's width.
+    private static final double SCALE = 1.5;
+
+    // Create a new expended paddle.


Corrected 'expended' to 'expanded' to match the intended functionality.

Suggested change

// Create a new expended paddle.

// Create a new expanded paddle.

Copilot · 2025-10-07T19:41:32Z

+    public void moveLeft() {}
+
+    // Move the paddle right.
+    public void moveRight() {}


The moveLeft() and moveRight() methods are empty implementations. These should either contain actual movement logic or be marked as abstract if this is intended as a base class for extension.

thnhmai06

LGTM

* feat: Brick * feat(brick): add PowerBrick and update Brick, ExoplodeBrick, ProtectedBrick * docs(brick): add Javadoc for Brick, ExoplodeBrick, PowerBrick, ProtectedBrick * refactor(brick): remove NormalBrick and StrongBrick * feat(paddle): add ExpendPaddle, LaserPaddle, ShrinkPaddle and update Paddle * feat(paddle): add ExpendPaddle, LaserPaddle, ShrinkPaddle and update Paddle * refactor: remove brick and gameManager packages * feat(brick): refactor and document brick module (Factory, Component, Protected, Explode) * feat(brick): Introduce brick components and behaviors - Added Brick, BrickHealth, BrickDrop, BrickExplode, and BrickFactory classes to manage brick entities and their behaviors (enhances gameplay mechanics). - Refactored existing classes to align with new component structure. * docs(brick): Corrected spelling of 'nheritance' to 'inheritance' Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refactor(brick): remove multiple Spawns annotation from newBrick methods Removed the @spawns annotation from the newBrick methods in BrickFactory to streamline the code and eliminate unnecessary complexity (no functional changes). --------- Co-authored-by: Mai Thành <62001770+thnhmai06@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ManhTanTran added 9 commits September 29, 2025 17:13

feat: Brick

6229cc2

feat(brick): add PowerBrick and update Brick, ExoplodeBrick, Protecte…

7418ab1

…dBrick

docs(brick): add Javadoc for Brick, ExoplodeBrick, PowerBrick, Protec…

b4f0622

…tedBrick

refactor(brick): remove NormalBrick and StrongBrick

89c507a

feat(paddle): add ExpendPaddle, LaserPaddle, ShrinkPaddle and update …

2453417

…Paddle

feat(paddle): add ExpendPaddle, LaserPaddle, ShrinkPaddle and update …

a493678

…Paddle

feat(paddle): add ExpendPaddle, LaserPaddle, ShrinkPaddle and update …

02e8c82

…Paddle

refactor: remove brick and gameManager packages

5e9ce2e

feat(brick): refactor and document brick module (Factory, Component, …

6af822f

…Protected, Explode)

Copilot AI review requested due to automatic review settings October 5, 2025 10:19

Copilot AI reviewed Oct 5, 2025

View reviewed changes

thnhmai06 self-requested a review October 7, 2025 10:38

thnhmai06 reviewed Oct 7, 2025

View reviewed changes

Comment thread src/main/java/com/github/codestorm/bounceverse/brick/BrickComponent.java Outdated

thnhmai06 reviewed Oct 7, 2025

View reviewed changes

feat(brick): Introduce brick components and behaviors

125ccc4

- Added Brick, BrickHealth, BrickDrop, BrickExplode, and BrickFactory classes to manage brick entities and their behaviors (enhances gameplay mechanics). - Refactored existing classes to align with new component structure.

thnhmai06 requested review from Copilot and thnhmai06 October 7, 2025 19:24

Copilot AI reviewed Oct 7, 2025

View reviewed changes

docs(brick): Corrected spelling of 'nheritance' to 'inheritance'

96b9a48

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings October 7, 2025 19:29

Copilot AI reviewed Oct 7, 2025

View reviewed changes

Comment thread src/main/java/com/github/codestorm/bounceverse/components/paddle/LaserPaddle.java

thnhmai06 added 2 commits October 8, 2025 02:34

refactor(brick): remove multiple Spawns annotation from newBrick methods

671f83c

Removed the @spawns annotation from the newBrick methods in BrickFactory to streamline the code and eliminate unnecessary complexity (no functional changes).

Merge remote-tracking branch 'origin/main' into brick

a0a11dd

# Conflicts: # .idea/misc.xml

Copilot AI review requested due to automatic review settings October 7, 2025 19:40

Copilot AI reviewed Oct 7, 2025

View reviewed changes

thnhmai06 approved these changes Oct 7, 2025

View reviewed changes

thnhmai06 merged commit cec4335 into main Oct 7, 2025
6 checks passed

thnhmai06 deleted the brick branch October 7, 2025 19:43

		List<Entity> entites = FXGL.getGameWorld().getEntities();
		for (Entity e : entites) {

	// Create a new expended paddle.
	// Create a new expanded paddle.

Conversation

ManhTanTran commented Oct 5, 2025

🧱 Summary

✨ Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thnhmai06 Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

thnhmai06 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants