Skip to content

[Feature] Implement logout function #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2020
Merged

[Feature] Implement logout function #42

merged 1 commit into from
Nov 29, 2020

Conversation

saseungmin
Copy link
Collaborator

@saseungmin saseungmin commented Nov 29, 2020 •
edited
Loading

  • with firebase auth and redux
  • change header status with localstorage

loginlogout

@saseungmin
[Feature] Implement logout function
434d318 
- with firebase auth and redux
- change header status
@saseungmin saseungmin added the enhancement New feature or request label Nov 29, 2020
saseungmin
saseungmin commented Nov 29, 2020
View reviewed changes
src/components/common/Header.jsx
{user ? (
<div>
<button type="button">로그아웃</button>
<span>{user}</span>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 지금은 사용자의 이메일을 헤더에 나타나는데 회원가입할 때 사용자의 이름도 같이 입력받아서 이름으로 나타내도 좋을거 같다.

@saseungmin
Copy link
Collaborator Author

  • 로그인 회원가입시 validation 체크가 아직 되어있지 않다. (추후 구현해주기)

@saseungmin saseungmin merged commit 8ed8ba8 into CodeSoom:main Nov 29, 2020
@saseungmin saseungmin mentioned this pull request Nov 29, 2020
Closed
20 tasks
@saseungmin saseungmin deleted the use-localstorage-and-logout branch July 5, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@saseungmin