Skip to content

Styles polishing #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 26, 2025
Merged

Styles polishing #3

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
367e48c
removed excessive comments
Sep 25, 2025
79c1646
improved colors and styles
Sep 25, 2025
6ac35a5
updated navbar styles
Sep 25, 2025
745f21f
updated port
Sep 26, 2025
77d6ef1
added vendor-specific appearance resets
Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion diagram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ function renderTable(svg, table, schema, selectedTableId, selectedColId, onSelec
title.textContent = table.name; g.appendChild(title);

// HEADER SEPARATOR
g.appendChild(createSvg('line', { x1: x, y1: y + DIAGRAM.HEADER_H, x2: x + width, y2: y + DIAGRAM.HEADER_H, stroke: '#e4e4e8' }));
g.appendChild(createSvg('line', { x1: x + 8, y1: y + DIAGRAM.HEADER_H, x2: x + width - 8, y2: y + DIAGRAM.HEADER_H, stroke: '#d1d5db', 'stroke-width': '0.5' }));

// DRAG BUTTON (the ONLY drag handle)
const btnSize = 16;
Expand Down
6 changes: 3 additions & 3 deletions server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# server.py (only the imports and do_POST change shown)
from http.server import SimpleHTTPRequestHandler
from socketserver import TCPServer
from urllib.parse import urlparse, parse_qs # ← add
from urllib.parse import urlparse, parse_qs
import json
import os

PORT = 3000
ALLOWED_FILES = {"test.json", "solution.json"} # ← add
PORT = 8000
ALLOWED_FILES = {"test.json", "solution.json"}
Copy link

@coderabbitai coderabbitai bot Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Confirm clients know about the port bump

Changing the listener from 3000 to 8000 is fine, but please double-check that any docs, scripts, or frontend fetches still hard-coding :3000 are updated, otherwise saves will start failing once this lands.

🏁 Script executed:

#!/bin/bash
# Inspect the repo for stale references to the old port/getting-started instructions.
rg -n "localhost:3000"
rg -nP '[:/]3000\b'

Length of output: 109

Replace stale port references

  • tests/README.md:110 – change localhost:3000 → localhost:8000
  • confirm no other hard-coded :3000 remain in docs or scripts
🤖 Prompt for AI Agents 
In server.py around lines 8 to 9, the project port constant is set to 8000 but
documentation and scripts still reference the old :3000; update tests/README.md
line ~110 from localhost:3000 to localhost:8000 and search the repository for
any remaining hard-coded ":3000" occurrences (including docs, scripts, CI
configs) and replace them with ":8000" or the PORT constant where appropriate to
ensure consistency.


class Handler(SimpleHTTPRequestHandler):
def log_message(self, format, *args):
Expand Down
7 changes: 4 additions & 3 deletions solution.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,10 @@
"uniqueConstraints": [],
"indexes": [],
"position": {
"x": 234,
"y": 109
}
"x": 85,
"y": -102
},
"color": "blue"
}
],
"foreignKeys": [
Expand Down
54 changes: 35 additions & 19 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,19 @@
/* Put these with your other :root vars */
:root {
/* header fills (light) */
--tbl-white: #ffffff;
--tbl-blue: #8eb3f0;
--tbl-green: #bbe5d1;
--tbl-red: #f8caca;
--tbl-white: #f4f6f8;
--tbl-blue: #8bd0f9;
--tbl-green: #b0f1a9;
--tbl-red: #ff8595;
}

@media (prefers-color-scheme: dark) {
:root {
/* darker tints that read well with white text */
--tbl-white: #4a5a7b; /* slate-ish */
--tbl-blue: #0c2658; /* deep blue */
--tbl-green: #07402d; /* deep green */
--tbl-red: #5d1d1d; /* deep red */
--tbl-blue: #5252b7; /* iris */
--tbl-green: #419f65; /* shamrock green */
--tbl-red: #df5353; /* deep red */
}
}

Expand Down Expand Up @@ -71,21 +71,21 @@
}

header{
display:flex;align-items:baseline;gap:1rem;padding:.75rem 1rem;
display:flex;align-items:center;gap:1rem;padding:.5rem 1rem; /* Reduced from .75rem to .5rem */
border-bottom:1px solid var(--stroke);
background:var(--box)
}

/* Light theme navigation bar background */
@media (prefers-color-scheme: light) {
header {
background: rgb(238, 239, 246);
background: #ffffff; /* Changed to white */
}
}
header h1{font-size:1.1rem;margin:0}
#status{font-size:.9rem;color:var(--muted)}

main.layout{display:grid;grid-template-columns:300px 1fr;height:calc(100% - 50px)}
main.layout{display:grid;grid-template-columns:300px 1fr;height:calc(100% - 42px)} /* Adjusted for smaller header */
#diagram-wrap{width:100%;height:100%}

#diagram{ background: var(--canvas); }
Expand Down Expand Up @@ -142,22 +142,27 @@

/* Input field specific styles (exclude checkboxes) */
input:not([type="checkbox"]) {
min-height: 3.75rem;
min-height: 3rem; /* Reduced from 3.75rem (20% reduction) */
max-height: 8.737499999999999rem;
padding-left: 1rem;
padding-right: 2.75rem;
padding-top: 0.94975rem;
padding-bottom: 0.94975rem;
padding-top: 0.75rem; /* Reduced from 0.94975rem */
padding-bottom: 0.75rem; /* Reduced from 0.94975rem */
}

/* Select field specific styles to match inputs */
select {
min-height: 3.75rem;
min-height: 3rem; /* Reduced from 3.75rem (20% reduction) */
max-height: 8.737499999999999rem;
padding-left: 1rem;
padding-right: 2.75rem;
padding-top: 0.94975rem;
padding-bottom: 0.94975rem;
padding-right: 3rem; /* Increased from 2.75rem to give arrow more space */
padding-top: 0.75rem; /* Reduced from 0.94975rem */
padding-bottom: 0.75rem; /* Reduced from 0.94975rem */
appearance: none; /* Remove default arrow */
background-image: url("data:image/svg+xml;charset=UTF-8,%3csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24' fill='none' stroke='%23666' stroke-width='2' stroke-linecap='round' stroke-linejoin='round'%3e%3cpolyline points='6,9 12,15 18,9'%3e%3c/polyline%3e%3c/svg%3e");
background-repeat: no-repeat;
background-position: right 0.75rem center; /* Position arrow with proper spacing */
background-size: 1rem;
}
Comment on lines 157 to 168
Copy link

@coderabbitai coderabbitai bot Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add vendor-specific appearance resets for selects

On Safari/iOS the native arrow won’t disappear unless -webkit-appearance: none is set, so the custom SVG arrow will render next to the system one. Please add the customary vendor-specific resets to keep the UX consistent.

 select {
-    min-height: 3rem; /* Reduced from 3.75rem (20% reduction) */
+    -webkit-appearance: none;
+    -moz-appearance: none;
+    min-height: 3rem; /* Reduced from 3.75rem (20% reduction) */
     max-height: 8.737499999999999rem;
     padding-left: 1rem;
     padding-right: 3rem; /* Increased from 2.75rem to give arrow more space */
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
min-height: 3rem; /* Reduced from 3.75rem (20% reduction) */
max-height: 8.737499999999999rem;
padding-left: 1rem;
padding-right: 2.75rem;
padding-top: 0.94975rem;
padding-bottom: 0.94975rem;
padding-right: 3rem; /* Increased from 2.75rem to give arrow more space */
padding-top: 0.75rem; /* Reduced from 0.94975rem */
padding-bottom: 0.75rem; /* Reduced from 0.94975rem */
appearance: none; /* Remove default arrow */
background-image: url("data:image/svg+xml;charset=UTF-8,%3csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24' fill='none' stroke='%23666' stroke-width='2' stroke-linecap='round' stroke-linejoin='round'%3e%3cpolyline points='6,9 12,15 18,9'%3e%3c/polyline%3e%3c/svg%3e");
background-repeat: no-repeat;
background-position: right 0.75rem center; /* Position arrow with proper spacing */
background-size: 1rem;
}
select {
-webkit-appearance: none;
-moz-appearance: none;
min-height: 3rem; /* Reduced from 3.75rem (20% reduction) */
max-height: 8.737499999999999rem;
padding-left: 1rem;
padding-right: 3rem; /* Increased from 2.75rem to give arrow more space */
padding-top: 0.75rem; /* Reduced from 0.94975rem */
padding-bottom: 0.75rem; /* Reduced from 0.94975rem */
appearance: none; /* Remove default arrow */
background-image: url("data:image/svg+xml;charset=UTF-8,%3csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24' fill='none' stroke='%23666' stroke-width='2' stroke-linecap='round' stroke-linejoin='round'%3e%3cpolyline points='6,9 12,15 18,9'%3e%3c/polyline%3e%3c/svg%3e");
background-repeat: no-repeat;
background-position: right 0.75rem center; /* Position arrow with proper spacing */
background-size: 1rem;
}
🤖 Prompt for AI Agents 
In style.css around lines 155 to 166, the select styling uses appearance: none
but misses vendor-specific resets so Safari/iOS still shows the native arrow;
add -webkit-appearance: none and -moz-appearance: none to the same rule and also
hide the IE/Edge dropdown arrow by adding a selector for select::-ms-expand {
display: none; } so the custom SVG arrow is the only visible control.


input:not([type="checkbox"]):hover, select:hover {
Expand Down Expand Up @@ -227,6 +232,16 @@
border-color: transparent;
}

/* Dark mode dropdown arrow */
select {
background-image: url("data:image/svg+xml;charset=UTF-8,%3csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24' fill='none' stroke='%23c1c7d7' stroke-width='2' stroke-linecap='round' stroke-linejoin='round'%3e%3cpolyline points='6,9 12,15 18,9'%3e%3c/polyline%3e%3c/svg%3e");
background-repeat: no-repeat;
background-position: right 0.75rem center;
background-size: 1rem;
padding-left: 1rem; /* Ensure left padding is maintained in dark mode */
padding-right: 3rem; /* Ensure right padding is maintained in dark mode */
}

input:not([type="checkbox"]):hover, select:hover {
border-color: #26314c;
}
Expand Down Expand Up @@ -307,10 +322,11 @@

/* --- help button alignment --- */
.spacer { flex: 1; }
#btn-help { margin-left: auto; }
#btn-help { margin-left: auto; margin-top: 0; }

.as-button {
display: inline-block;
display: inline-flex;
align-items: center;
padding: .5rem .75rem;
border: 1px solid #e2e8f0;
border-radius: .5rem;
Expand Down
Loading