Offline instrumentation support#630
Merged
bertschneider merged 1 commit intoCodeIntelligenceTesting:mainfrom Mar 7, 2023
Merged
Offline instrumentation support#630bertschneider merged 1 commit intoCodeIntelligenceTesting:mainfrom
bertschneider merged 1 commit intoCodeIntelligenceTesting:mainfrom
Conversation
Contributor
bertschneider
left a comment
bertschneider
left a comment
There was a problem hiding this comment.
Thx for the contribution, it's very appriciated! Averall this looks good, I mainly added styling and cleanup hints. Some questions are still in the comments, though.
src/main/java/com/code_intelligence/jazzer/instrumentor/Hooks.kt
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/driver/OfflineInstrumentor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/driver/OfflineInstrumentor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/driver/OfflineInstrumentor.java
Show resolved
Hide resolved
TheCoryBarker
force-pushed
the
OfflineInstrumentationSupport
branch
from
bc75d16 to
795bbed
Compare
Contributor
Author
|
Thank you for the feedback, I have addressed the comments, but had a couple questions |
src/main/java/com/code_intelligence/jazzer/driver/OfflineInstrumentor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/driver/OfflineInstrumentor.java
Show resolved
Hide resolved
bertschneider
approved these changes
Mar 6, 2023
Contributor
bertschneider
left a comment
bertschneider
left a comment
There was a problem hiding this comment.
Looks good now. Thanks for the contribution!
For another PR: Could you please provide some documentation on how one would use the new Android features?
bertschneider
force-pushed
the
OfflineInstrumentationSupport
branch
from
c83433c to
fd4d58c
Compare
Contributor
|
I rebased your PR on |
TheCoryBarker
force-pushed
the
OfflineInstrumentationSupport
branch
from
fd4d58c to
0eccbd6
Compare
Contributor
Author
|
does it look correct now? |
Contributor
|
Great. Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.