Fix for duplicate values using setState with initially selected items #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for duplicate values appearing for each call to setState when initializing MultiSelectContainer with pre-selected items. For example when initializing
MultiSelectContainer
like this:In the above example I am setting some of the initial
_myItems
toselected: true
based on their existence in_mySelectedItems
.The reason the selected values were being duplicated is because
didUpdateWidget
would call_addInitiallySelectedItemsToSelectedList
which would blindly add those items to_selectedItems
. This is OK ininitState
because it is only called once when the widget is created. But it is a problem indidUpdateWidget
because it is called whenever the widget is updated, thus adding the same items to_selectedItems
again and again.