-
Notifications
You must be signed in to change notification settings - Fork 21
Dynamic page titles #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dschwindt
wants to merge
7
commits into
CodeForBoulder:main
Choose a base branch
from
dschwindt:dynamic-page-titles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dynamic page titles #503
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f89cf5f
added instructions for wsl2 installation
dschwindt 516349b
Merge branch 'CodeForBoulder:main' into main
dschwindt 330aa17
updated wsl2 instructions to incorporate comments
dschwindt c727c4a
Merge branch 'CodeForBoulder:main' into main
dschwindt 7e6e395
Merge branch 'CodeForBoulder:main' into main
dschwindt 9a2f205
Merge branch 'CodeForBoulder:main' into dynamic-page-titles
dschwindt 2bf51fe
add dynamic page titles including translations
dschwindt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,20 @@ | ||
import AlgoliaBadge from "./AlgoliaBadge"; | ||
import Container from "@material-ui/core/Container"; | ||
import { Grid } from "@material-ui/core"; | ||
import { Helmet } from "react-helmet"; | ||
import HomeButtons from "./HomeButtons"; | ||
import React from "react"; | ||
import SearchForm from "./SearchForm"; | ||
import { useTranslation } from "react-i18next"; | ||
|
||
const Home = () => { | ||
const { t } = useTranslation("footer"); | ||
const { t } = useTranslation(["footer", "home"]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another options could be removing the specific name space here and just applying it within the t function, e.g.: const { t } = useTranslation();
// ...other stuff in between
<Helmet>
<title>{t("home.title")}</title>
<meta name="description" content={t("home.description")} />
</Helmet> NBD either way but thought this may be a bit easier to read. |
||
return ( | ||
<Container> | ||
<Helmet> | ||
<title>{t("title", { ns: "home" })}</title> | ||
<meta name="description" content={t("description", { ns: "home" })} /> | ||
</Helmet> | ||
<Grid | ||
alignItems="stretch" | ||
container | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on creating a utility that centralized appending the "- UpSwyng" to the title? Could create something like
seo.js
in the utils folder and create amakePageTitle
that accepts a string as an argument and just returns that appended with- UpSwyng
.