build(payload): fix images not loading #1334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also configure S3 plugin with maxAttempts and signedDownloads options
Add ft/upgrade-payload branch to trigger dev deployment for testing purposes
kilemensi
reviewed
Oct 17, 2025
|
For our case (or at least for today), if the upgrade doesn't fix this issue then this looks like a promising fix i.e. increase |
|
... and again, I believe building Docker locally on M3 Pro should be faster than on a GitHub Action so you should be able to test and iterate much faster that way. I believe you have values for all of these envs/secrets (and they should also be in the vault). |
Add S3_MAX_ATTEMPTS, S3_MAX_SOCKETS and S3_CONNECTION_TIMEOUT env variables to configure S3 client connection settings. This improves reliability and performance of S3 operations. ci: remove temporary testing branch from workflow refactor(incubator): add title prop and Typography component
koechkevin
approved these changes
Oct 17, 2025
kilemensi
approved these changes
Oct 17, 2025
| "S3_SECRET_ACCESS_KEY", | ||
| "S3_MAX_ATTEMPTS", | ||
| "S3_MAX_SOCKETS", | ||
| "S3_CONNECTION_TIMEOUT", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to address an issue where images intermittently load.
Similar issues
payloadcms/payload#6382
payloadcms/payload#12366
A few individuals facing the issue have resolved it by updating to the latest version and serving the files directly from S3 by using the
signedDownloads: trueType of change
Screenshots
Checklist: