-
Couldn't load subscription status.
- Fork 7
Update/api_views: data endpoint #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Use node uid instead of sensor id as it is more readable. Make location country to be a dropdown. Add sensor type filter
Sampling rate, DB record id, software version etc not needed
|
@thepsalmist This is what I meant about the sensor name instead of the id. We can keep the sensor id and add sensor_type name or update sensor value to the name instead of the id. Whichever is acceptable. I thought you had commented on this PR yesterday 🤔
|
Makes sense @gideonmaina , I ad commented on issue #152 . I got it covered, including a number of optimizations from the serializers we inherited from feinstaub. Should have the PR up tomorrow |
|
@thepsalmist I would like to first test out the casting for the PM value types |
|
@thepsalmist. I have made the final changes to this issue #152. Please continue with the review . Cc. @usmanbiu
|
|
@gideonmaina great job!! |
|
@usmanbiu That information is useful for node details. For mobile sensors, that is part of the data already
|





Description
Update the
/dataendpoint by adding more filtering options and omitting unnecessary dataType of change
New feature (non-breaking change which adds functionality)
Add filtering options by
node uid,node owner,sensor type namechoices andcountry namechoices.Breaking change (fix or feature that would cause existing functionality not to work as expected)
sensor id: this approach is cumbersome as it requires tracking sensors by their PKs. A node uid is sufficient for the user and further filtering can be done by sensor types inside the node.This change requires a documentation update
Screenshots
Checklist: