Switch to JSON format for Nginx logs #11
Conversation
maquchizi
commented
Jan 29, 2026
maquchizi
commented
- This will allow us to parse logs better in Grafana
@kilemensi Codex doesn't want to cooperate. Perhaps it needs some set up for this repo? |
|
@codex review |
Yeah, https://github.com/CodeForAfrica/ghost wasn't connected @maquchizi . Should be good now. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0cdf36cf85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| server_name {{ .NOSSL_SERVER_NAME }}; | ||
|
|
||
| access_log /var/log/nginx/{{ .APP }}-access.log; | ||
| access_log /var/log/nginx/{{ .APP }}-access.log json; |
There was a problem hiding this comment.
This server block now writes JSON to /var/log/nginx/{{ .APP }}-access.log, but the HTTPS server block below still writes to the same file without the json format. In deployments where HTTPS handles most traffic, the access log will therefore mix JSON and default log lines, which breaks JSON-only parsing (e.g., in Grafana) or drops entries. If the goal is to switch to JSON logs, the 443 access_log should use the same json format or a separate file.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
OMG! This is actually a good catch. I forgot to change the format in the HTTPS block.
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
@VinneyJ We can add the upstream stuff at a later point if needed. Better to have only the relevant metrics for our current use case. |
4 participants
