Skip to content

Log Layout Time Less Religiously #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Log Layout Time Less Religiously #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Sources/CodeEditTextView/TextLayoutManager/TextLayoutManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,13 @@ public class TextLayoutManager: NSObject {
let end = mach_absolute_time()
let elapsed = end - start
let nanos = elapsed * UInt64(info.numer) / UInt64(info.denom)
let msec = TimeInterval(nanos) / TimeInterval(NSEC_PER_MSEC)
logger.info("TextLayoutManager built in: \(msec, privacy: .public)ms")
let sec = TimeInterval(nanos) / TimeInterval(NSEC_PER_SEC)
// This used to be logged every time. However we're now confident enough in the performance of this method
// that it's not useful to log it anymore unless it's an odd number. Taking ~500ms for a >500k loc file
// is normal. More than 1s for any document is not normal.
if sec >= 1 {
logger.warning("TextLayoutManager built in: \(sec, privacy: .public)s")
}
#endif
}

Expand Down