Skip to content

Line number color fixes#169

Merged
lukepistrol merged 7 commits intoCodeEditApp:mainfrom
luah5:line-number-colour-fixes
Mar 26, 2023
Merged

Line number color fixes#169
lukepistrol merged 7 commits intoCodeEditApp:mainfrom
luah5:line-number-colour-fixes

Conversation

@luah5
Copy link
Member

@luah5 luah5 commented Mar 26, 2023 •
edited
Loading

Description

this PR slightly changes the color of the line numbers, making it slightly darker

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code
  • Change the line number color

Screenshots

shot 2
shot 3

lukepistrol
lukepistrol reviewed Mar 26, 2023
View reviewed changes
@luah5 luah5 marked this pull request as draft March 26, 2023 10:17
@luah5 luah5 marked this pull request as ready for review March 26, 2023 10:46
@austincondiff austincondiff self-requested a review March 26, 2023 17:54
austincondiff
austincondiff requested changes Mar 26, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach is overlay verbose. All that is necessary is .labelColor for the current line number and .secondaryLabelColor for all of other line numbers.

austincondiff
austincondiff requested changes Mar 26, 2023
View reviewed changes
luah5 and others added 2 commits March 26, 2023 19:30
@luah5 @austincondiff
Update Sources/CodeEditTextView/Controller/STTextViewController.swift
a46f20b 
Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
@luah5 @austincondiff
Update Sources/CodeEditTextView/Controller/STTextViewController.swift
a83075a 
Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
@luah5 luah5 requested a review from austincondiff March 26, 2023 18:31
@luah5
Copy link
Member Author

luah5 commented Mar 26, 2023

This approach is overlay verbose. All that is necessary is .labelColor for the current line number and .secondaryLabelColor for all of other line numbers.

silly me, it was a very quick fix that didn't need that extra code

@lukepistrol lukepistrol merged commit 87c96ff into CodeEditApp:main Mar 26, 2023
@luah5 luah5 deleted the line-number-colour-fixes branch March 26, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@austincondiff austincondiff austincondiff approved these changes

@lukepistrol lukepistrol lukepistrol approved these changes

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐞 Line Number default color too prominent

4 participants

@luah5 @austincondiff @lukepistrol @pythonista5