Skip to content

Fix Background Color Issue in Empty State #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2022

Conversation

lilingxi01
Copy link
Member

@lilingxi01 lilingxi01 commented May 1, 2022

Description

Fix the background material issue while there is no file opened (and the selected tab bar style is xcode).

For now, I keep background the same under native tab bar style.

Related Issue

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

CleanShot 2022-05-01 at 14 22 43@2x

CleanShot 2022-05-01 at 14 22 28@2x

Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@austincondiff austincondiff merged commit ac128a2 into CodeEditApp:main May 1, 2022
@lilingxi01 lilingxi01 deleted the editor-background-fix branch May 1, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants