Add breadcrumb dropdown menu#249
Conversation
|
Cool, just curious why are you wrapping menu in |
|
If not wrap with |
Instead of wrapping in @ViewBuilder
private func menuItem(_ item: WorkspaceClient.FileItem) -> some View {
if let children = item.children?.sortItems(foldersOnTop: true), !children.isEmpty {
Menu { … }
} else {
Button { … }
}
} |
Have tried that. Still got compiler error. Because this function will be called recursively. |
71341b5 to
0a52268
Compare
|
Remove |
367ee1c to
743e8b3
Compare
|
I guess colors inside the context menu aren't working for now |
|
From testing this in a pretty barebones Untitled.mov |
While in menu, colors of Text works. |
Yep, I'm trying to optimize it. |
|
It's a little difficult to optimize it based on SwiftUI's Menu, because it can't refresh view when data changes. I wanted to rewrite it with Popover but SwiftUI's Popover cannot remove the arrow. |
|
Convert to draft. I'm working on rebuilding it with NSMenu. |
ca8f7e9 to
58f9cff
Compare
58f9cff to
caae42c
Compare

Description
This PR will support breadcrumbs dropdown menu mentioned in #248
Releated Issue
#248
Checklist (for drafts):
Screenshots (if appropriate):