Fixing build problem for Xcode 15

[bombardier200]

Description

Updates Swiftui-windowmanagement to latest version to fix CodeEdit from not building on Xcode15.

Related Issues

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

[matthijseikelenboom]

This would require everyone that is developing on CodeEdit to update to Xcode 15. Do we want to enforce that already?

[bombardier200]

I built this on Xcode 14 and it worked?

[matthijseikelenboom]

Nvm then, I've said nothing haha

[bombardier200]

@matthijseikelenboom I had a caching problem and now it is failing to build with this change on Xcode 14.

[bombardier200]

@Wouter01 do you know the easiest way to keep it building on both Xcode 14 and 15?

[Wouter01]

@bombardier200 I do not at the moment. But, given that the amount of usage of swift 5.9 exclusive features will increase in the codebase rapidly (swiftlint has new style guides etc) I think requiring Xcode 15 is fine. It also works on Ventura so everyone should be able to upgrade

[austincondiff]

Where are we on this?

[matthijseikelenboom]

It's a principle decision if everyone should be forced to start using Xcode 15, because if it's merged, you can't use Xcode 14 anymore

[austincondiff]

But all that has changed was @Wouter01's window package version number. This package version is not compatible with Xcode 14?

[matthijseikelenboom]

It seems like it isn't, no

[Wouter01]

But all that has changed was @Wouter01's window package version number. This package version is not compatible with Xcode 14?

The package is compatible with Xcode 14. However, the new environment modifier introduced in SwiftUI (https://developer.apple.com/documentation/swiftui/scene/environment(_:_:)) is not available in Xcode 14. A possibility would be to add compiler flags (#if swift version > 5.9 ...), but it's rather unnecessary. @matthijseikelenboom, is there a reason we shouldn't jump to Xcode 15? It's generally not a good idea to mix different Xcode versions (and different swift toolchains)

[matthijseikelenboom]

@Wouter01 Oh I'm not against updating to Xcode 15, but I think it has to be a conscious decision

[austincondiff]

@lukepistrol would we need an update to our test runner for this? Can you do this?

[lukepistrol]

@austincondiff I can definitely update to Xcode 15. Just let me know

[austincondiff]

@lukepistrol I updated macOS and downloaded Xcode 15 and put it in the Applications folder. Is there anything else we need to do?

[lukepistrol]

@lukepistrol I updated macOS and downloaded Xcode 15 and put it in the Applications folder. Is there anything else we need to do?

Maybe just a brew upgrade.

[austincondiff]

@lukepistrol I did a brew update and brew upgrade and then ran a test. Same result. Any other ideas?

[austincondiff]

Closing because this was necessary and was merged with #1441.