Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug area tabs #1261

Merged
merged 22 commits into from
Jun 4, 2023
Merged

Debug area tabs #1261

merged 22 commits into from
Jun 4, 2023

Conversation

bombardier200
Copy link
Contributor

@bombardier200 bombardier200 commented May 8, 2023 •
edited by austincondiff
Loading

Description

Moves debug area tabs from status bar to new debug area sidebar. Places terminal tabs as children of "Terminal" debug area sidebar top-level item.

Related Issues

Checklist

  • Remove debug area tabs from the status bar
  • Add icon tabs - terminal, debug, and output
  • Add terminal tabs to list in terminal view sidebar
  • Add debug area sidebar
  • Add toolbar to debug area sidebar
  • Enable user to toggle visibility of debug area sidebar
  • Place toggle button in debug area sidebar toolbar
  • Place add button in debug area sidebar toolbar
  • Place remove button in debug area sidebar toolbar
  • Add terminal tab when add button is clicked
  • Remove selected terminal tab when remove button is clicked
  • Create and use reusable view for debug area tabs
  • Pull extension output into debug area output tab
  • Enable functionality to clear output in output tab
  • Enable functionality to filter output in output tab
  • Combine area tab bar views into single reusable view
  • Use the terminal title as the tab title*
  • Use custom title instead of terminal title after renaming a tab*
  • After maximizing the debug area and then un-maximizing, go back to height debugger area was before maximizing*
  • Retain tab state when switching debug area tabs and switching back*
  • Allow users to rename terminal tabs
  • Allow users to select terminal type
  • When terminal sidebar is collapsed, provide picker menu
  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

* Optional – can be scoped into a future PR

Screenshots

Screen.Recording.2023-05-25.at.4.49.57.PM.mp4

@austincondiff austincondiff changed the title Debugger area tabs Debug area tabs May 23, 2023
@austincondiff
Added icon tabs to the left of the debug area. Added sidebar to termi…
8e0b3a6 
…nal view listing terminal tabs. Added functionality to add and remove tabs.
@austincondiff austincondiff marked this pull request as ready for review May 25, 2023 21:57
@austincondiff austincondiff marked this pull request as draft May 25, 2023 21:57
austincondiff and others added 11 commits May 25, 2023 22:23
@austincondiff
Added functionality to rename and drag to reorder along with context …
ed6dd0e 
…menus.
@bombardier200
Adding terminalType selector
0f99f91
@bombardier200
Fix SwiftLint error
5ea6260
@austincondiff
Added terminal tab picker when sidebar is collapsed.
9d3cfcf
@austincondiff
Renamed StatusbarViewModel to DebugAreaViewModel. Enabled multi-selec…
80f2e6e 
…t and deleting multiple terminal tabs at once.. Enabled users to maximize debug area
@austincondiff
Fixed build error
e3e4976
@austincondiff
Changed the title until we can get the updated terminal title
4cec1aa
@austincondiff
Added DebugAreaTabView to simplify each of our debug area tab views.
924a19f
@austincondiff
Merged with main. Extensions now output to output debug area tab. Ena…
98013a2 
…bled clearing and filtering.
@austincondiff
Minor fixes
ba09a97
@austincondiff @Wouter01
Combined area tab bar views into single reusable view (#1289)
1b153ba 
* Refactored to combine all area tab bars including NavigatorTabBar, InspectorTabBar, and DebugAreaTabBar into one reusable view.

* put back enums, added TabBar protocol

Signed-off-by: Wouter01 <wouterhennen@gmail.com>

* A few minor naming changes. Moved AreaTabs protocol to AreaTabBar file

---------

Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Co-authored-by: Wouter01 <wouterhennen@gmail.com>
@austincondiff austincondiff marked this pull request as ready for review June 2, 2023 16:33
@austincondiff austincondiff mentioned this pull request Jun 3, 2023
Closed
@Wouter01
Better fix for debug model updates to view
da93714 
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
@austincondiff austincondiff requested a review from 0xWDG June 3, 2023 19:20
@bombardier200 bombardier200 merged commit 8fae08c into main Jun 4, 2023
@bombardier200 bombardier200 deleted the debugger-area-tabs branch June 4, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff left review comments

@Wouter01 Wouter01 Wouter01 approved these changes

@0xWDG 0xWDG 0xWDG approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Bottom Drawer Navigation
4 participants
@bombardier200 @austincondiff @0xWDG @Wouter01