Skip to content

feat(pinia-orm): STI Models can only be retrieved through parent #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024

Conversation

CodeDredd
Copy link
Owner

@CodeDredd CodeDredd commented May 6, 2024

πŸ”— Linked issue

closes #1735

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It's more an enhancment than a bugfix. The problem in this issue was that the child models didn't had a default @type value
on which a where clause was filtering. Added now entity as fallback if no default value for type is defined.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@CodeDredd CodeDredd changed the title fix(pinia-orm): STI Models can only be retrieved through parent feat(pinia-orm): STI Models can only be retrieved through parent May 6, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 99.71%. Comparing base (807fa36) to head (5a2da94).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1835   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          88       88           
  Lines        6027     6030    +3     
  Branches      511      512    +1     
=======================================
+ Hits         6010     6013    +3     
  Misses         13       13           
  Partials        4        4           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STI Models can only be retrieved through parent
2 participants