fix issue HubSpot/pace#261 by localizing key per loop in extendNative#504
Merged
FranDias merged 1 commit intoCodeByZach:masterfrom Nov 4, 2020
Merged
fix issue HubSpot/pace#261 by localizing key per loop in extendNative#504FranDias merged 1 commit intoCodeByZach:masterfrom
FranDias merged 1 commit intoCodeByZach:masterfrom
Conversation
a2intl
commented
Nov 4, 2020
| this.el.className = "pace pace-active"; | ||
| document.body.className = document.body.className.replace(/pace-done/g, ''); | ||
| document.body.className += ' pace-running'; | ||
| if (!/pace-running/.test(document.body.className)) { |
Contributor
Author
There was a problem hiding this comment.
Note: this was a fix already in the coffeescript but not yet compiled to the javascript.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
XMLHttpRequest.DONEvalue is getting set to the last-iterated-property-value inextendNative, which, at least in Chrome, isƒ removeEventListener() { [native code] }, when it should be4.We encountered this problem breaking a
req.readyState===XMLHttpRequest.DONEcondition implemented in the iabtcf-es library by our consent manager, Quantcast Choice, by a user using the Wordpress plugin https://github.com/dcooney/wordpress-ajax-load-more