fix ComboBox popover opened by default#574
Open
CyrilPaulus wants to merge 1 commit intoCodeBeamOrg:devfrom
Open
fix ComboBox popover opened by default#574CyrilPaulus wants to merge 1 commit intoCodeBeamOrg:devfrom
CyrilPaulus wants to merge 1 commit intoCodeBeamOrg:devfrom
Conversation
Contributor
|
Im not sure this fix is proper for an z-index issue. The always-open popover model is one of the main part of combobox, it increases the first load time, but reduces other processes overhead. Do you think this is the only solution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes #573.
The popover of the
ComboBoxis always opened which breaks functionnality when theCombBoxis inside another popover.Binding it to
_isOpenfix the problem.