Added option to only show keys which have a modifier #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y to work only with keymaps file. Maybe shortcutOnly should be renamed or better explained?
Merged
|
I didn't try it out, but it sounds perfect! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed shortcutOnly to work only with keymaps file. Maybe shortcutOnly should be renamed or better explained? This is a rework and split into smaller commit of #151 and should resolve issue #94.
After looking into the code as I understand it the show only shortcuts was meant to only display key pressed which are listed in the keymaps yaml files and it is per process. The naming is misleading.
As evidenced by issue #94
But in the process of adding the merge function and reusing the Message(IEnumerable keys, KeyShortcut shortcut) constructor. All the merged text and x times got a isShortcut=true.
Therefore in the current state Only Shortcut shows everything except modifier keys without keympas file and individual characters. By adding a third argument which is only passed from the ShortcutAccumulator the original function is restored.
But this does not solve the problem to have a feature to only show "shortcut keys" meaning any combination of alt,ctrl,shift, windows keys. Those are also called modifiers keys. So I added an option to only display modifiers keys throughout any process.