Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Conversation

@rydente
Copy link
Collaborator

@rydente rydente commented Apr 13, 2017

Introduce Cucumber as an acceptance testing and feature collaboration
system to OkCandidate so we can define and verify the system from a
functional perspective based on the users' perspectives.

Signed-off-by: Ryan Y ryayak1460@protingumas.com

Introduce Cucumber as an acceptance testing and feature collaboration
system to OkCandidate so we can define and verify the system from a
functional perspective based on the users' perspectives.

Signed-off-by: Ryan Y <ryayak1460@protingumas.com>
@wbprice
Copy link
Member

wbprice commented Apr 14, 2017

What are the specific challenges with using the JavaScript implementation of Cucumber?

@rydente
Copy link
Collaborator Author

rydente commented Apr 14, 2017

@wbprice From reading the recent documentation and checking up on collaborating toolsets, the teams involved may have mitigated them, but last I used it (November of last year):

  • every step had to return a Promise;
  • the headless browser (Zombie.js) hadn't had an update in a long time;
  • Zombie didn't work properly in certain cases (cookies and ignoring self-signed certificates came to mind);

As a result, it read poorly (generally, features, scenarios and steps should read very, very clearly) and had lots of little bugs which made implementing steps take far longer than normal, made them flakier and harder to debug when they went wrong.

However, I'm still in the process of writing up a bdd-js PR that I will send out soon, at latest tomorrow, so would you want to wait for that to come in and make a decision then?

EDIT: It doesn't seem as bad as it used to. I'll put up two gists to compare how tests look and link to each.

Here's the Ruby gist. The related PR below gives the Cucumber.js example.

Ryan Y added 2 commits April 14, 2017 13:27
Merge branch 'develop' into bdd-ruby to integrate the Cucumber setup
with the latest implementation.

Signed-off-by: Ryan Y <ryayak1460@protingumas.com>
Merge branch 'develop' into bdd-ruby to integrate the Cucumber setup
with the latest implementation.

Signed-off-by: Ryan Y <ryayak1460@protingumas.com>
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this here if we have a LICENSE file in the project root.

@wbprice
Copy link
Member

wbprice commented Apr 15, 2017

Closing this because we're probably going to use the JS implementation of Cucumber.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants