This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Inline alert component #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage, and dismiss function.
qwo
reviewed
Jun 15, 2017
| if (alertLevels.includes(this.props.level)) { | ||
| levelClass = this.props.level; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
let levelClass = alertLevels[this.props.level] || 'info'; be cleaner or harder to understand?
Member
There was a problem hiding this comment.
after talking to blaine its fine left as is.
we dont want css class 🥔 after all.
qwo
approved these changes
Jun 16, 2017
| if (alertLevels.includes(this.props.level)) { | ||
| levelClass = this.props.level; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
after talking to blaine its fine left as is.
we dont want css class 🥔 after all.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alert component that behaves like Bootstrap inline alerts.