Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close the file before deleting it #63

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

fisherzrj
Copy link
Contributor

@fisherzrj fisherzrj commented Sep 13, 2023

  • When deleting files, open files should be closed first
  • Windows does not support deleting open files

Fixes: #60

Copy link
Owner

@Code-Hex Code-Hex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #63 (f2ed0b9) into master (8f357a2) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   70.27%   70.27%           
=======================================
  Files           7        7           
  Lines         508      508           
=======================================
  Hits          357      357           
  Misses        112      112           
  Partials       39       39           
Files Changed Coverage Δ
download.go 73.62% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Code-Hex Code-Hex merged commit fcc53a2 into Code-Hex:master Sep 14, 2023
2 of 3 checks passed
@fisherzrj fisherzrj deleted the fix/process-occupation branch September 14, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to remove file -- being used by another process
2 participants