Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix partial file path #58

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

littlecxm
Copy link
Contributor

  • should use same func generate partial file path
  • should use filepath.Join to solve cross-platform path
    name := fmt.Sprintf("%s/%s.%d.%d", partialDir, c.Filename, c.Procs, i)

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #58 (419ada5) into master (8f357a2) will decrease coverage by 1.84%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   70.27%   68.44%   -1.84%     
==========================================
  Files           7        7              
  Lines         508      507       -1     
==========================================
- Hits          357      347      -10     
- Misses        112      120       +8     
- Partials       39       40       +1     
Impacted Files Coverage Δ
download.go 67.61% <75.00%> (-6.02%) ⬇️
util.go 91.17% <100.00%> (+1.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Code-Hex Code-Hex merged commit d112763 into Code-Hex:master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants