-
Notifications
You must be signed in to change notification settings - Fork 51
UPDATE endpoint for updating an anthology in a library #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
SlothfulDreams
wants to merge
21
commits into
Code-4-Community:main
from
Code-4-Community:bz-update-anthology
Closed
UPDATE endpoint for updating an anthology in a library #92
SlothfulDreams
wants to merge
21
commits into
Code-4-Community:main
from
Code-4-Community:bz-update-anthology
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature: added anthology controller
Implemented Anthology Module and small update to Anthology Controller
story service file
Create library entity
Add API routes to list and create anthologies
|
opps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #15
📝 Description
Implements the UPDATE endpoint for anthologies letting users to modify existing anthology records by ID.
Briefly list the changes made to the code:
PUT /library/anthology/:anthologyIdendpoint to `LibraryControllerupdateAnthology()method in `LibraryService✔️ Verification
Wrote 5 test cases in library.controller.spec.t
Used
yarn test library.controller.spec.tto test.All original + old test all passes
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!