Add labels #68
Closed
Add labels #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup & create task, category
sorry, updated this after I pushed so just gonna change it here too
Create label entity and corresponding migration
Mn 15/setup and seeding
…ndling and write tests
add npm run test
Create CODEOWNERS
AA-3: Create Task Route
setup frontend tickets
24 Create 4 Boxes
AA-6: Edit Task Route
implemented/tested delete_labels route
Increased responsiveness by positioning the task title and due date text relative to each other (instead of using absolute positioning)
AA-25: Create Task
|
for some reason when I make PRs keep getting redirected to this repo instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes
📝 Description
Added add_label endpoint with DTO Validation to link labels to a given task. Modified remove_label endpoint to reflect the same DTO as well.
✔️ Verification
Did unit tests of the service layer and controller layer, business logic for if task/label ids actually exist
Relied on ValidationPipe for type checking, so used Postman to check:
passing in string for taskId: 400
passing in empty label list: 400
passing in invalid string item in labelid list:
passing in non-existent task id
:
passing in non-existent label id:
passing in success to add labels
