Get all users route #69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nourshoreibah
requested changes
Oct 25, 2025
| @@ -1 +1 @@ | |||
| DATABASE_URL=postgresql://branch_dev:password@localhost:5432/branch_db | |||
| DATABASE_URL=postgresql://branch_dev:password@localhost:5433/branch_db | |||
|
|
||
| const users = await db | ||
| .selectFrom('branch.users') | ||
| .selectAll() |
There was a problem hiding this comment.
Suggested change
| .selectAll() | |
| .selectAll() | |
| .orderBy('user_id', 'asc') |
Need this to make sure tests pass since it depends on users being ordered by id
| expect(body.users.length).toBe(3); | ||
|
|
||
| const firstUser = body.users[0]; | ||
| expect(firstUser.created_at).toBe("2025-10-20T21:19:52.978Z"); |
There was a problem hiding this comment.
Suggested change
| expect(firstUser.created_at).toBe("2025-10-20T21:19:52.978Z"); |
Created at is a little too brittle of a test since we all set up our DBs at different times
| expect(body.users.length).toBe(1); | ||
|
|
||
| const firstUser = body.users[0]; | ||
| expect(firstUser.created_at).toBe("2025-10-20T21:19:52.978Z"); |
There was a problem hiding this comment.
Suggested change
| expect(firstUser.created_at).toBe("2025-10-20T21:19:52.978Z"); |
| expect(secondUser.user_id).toBe(2); | ||
|
|
||
| const thirdUser = body.users[2]; | ||
| expect(thirdUser.created_at).toBe("2025-10-20T21:19:52.978Z"); |
There was a problem hiding this comment.
Suggested change
| expect(thirdUser.created_at).toBe("2025-10-20T21:19:52.978Z"); |
| expect(firstUser.user_id).toBe(1); | ||
|
|
||
| const secondUser = body.users[1]; | ||
| expect(secondUser.created_at).toBe("2025-10-20T21:19:52.978Z"); |
There was a problem hiding this comment.
Suggested change
| expect(secondUser.created_at).toBe("2025-10-20T21:19:52.978Z"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #49
📝 Description
Added GET /users endpoint to retrieve users from the database. Optional pagination with page number and limit implemented.
Briefly list the changes made to the code:
✔️ Verification
Wrote Jest tests as well as checked different cases on Swagger to ensure it was working.
🏕️ (Optional) Future Work / Notes
Perhaps having user authentication for who can get users?