Patch user #67
Merged
Patch user #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nourshoreibah
requested changes
Oct 25, 2025
There was a problem hiding this comment.
This looks really good! Only thing is the tests should work regardless of the state of the DB. For the 1st test, you could make sure a user exists and then edit that one, and so maybe find an id then pass it to the endpoint, and make the test auto pass with a warning or something if DB empty? For the 2nd test, you can pick an id one higher than the highest id.
We could definitely have an even less brittle testing setup using transactions and rollback, but for now we can go with this
nourshoreibah
approved these changes
Oct 25, 2025
nourshoreibah
added a commit
that referenced
this pull request
Oct 25, 2025
This reverts commit d148307.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #51
📝 Description
patches user , takes in email, body, and isadmin
✔️ Verification
wrote tests
🏕️ (Optional) Future Work / Notes
auth guard + do we want to change isAdmin?