test(auth, anthology): add GET endpoint tests, mock AuthService/Users… #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Service, and fix lint errors - Added comprehensive tests for AnthologyController GET endpoints (findOne, findAll, getStories) - Mocked AuthService and UsersService in AuthController tests to resolve dependency injection errors - Fixed ESLint no-explicit-any errors in Anthology tests by replacing 'as any' with type-safe casts - Verified all backend test suites pass successfully and all lint checks are clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Service, and fix lint errors
ℹ️ Issue
Closes #18
📝 Description
This PR improves backend test reliability and coverage across both the AuthController and AnthologyController.
Previously, tests for the Auth module were failing due to missing provider dependencies (AuthService, UsersService), and the Anthology test suite contained any-type usage that triggered lint errors. These changes ensure both modules are fully covered, type-safe, and compliant with the NestJS testing framework.
Briefly list the changes made to the code:
✔️ Verification
Added 10 tests to anthology.controller.spec.ts to verify success of endpoint. All tests passed.
Provide screenshots of any new components, styling changes, or pages.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!