-
Notifications
You must be signed in to change notification settings - Fork 5
fix: valgrind crash for unresolved libpython #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: valgrind crash for unresolved libpython #82
Conversation
5b91bf8
to
72d5f05
Compare
I feel like a shell script might make the logic of finding the dir and creating the symlink a bit more clear. The downside is that we won't have direct insights into what failed. However, we could add some stderr logs which we can show in case of a crash/fail. @art049 @GuillaumeLagrange wdyt? |
72d5f05
to
0c95d86
Compare
A few changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's nice, yes. It seems better to have this logic in a shell script. Can you include it using include!
so we can benefit from syntax highlighting and linting (I use shellcheck locally, for example. We probably don't need to include this lint in CI, though.
ae7bc14
to
940e5ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
we might have to refine a bit the way we find the Python executables we need to patch but this will do for now ! |
940e5ca
to
a6e9d2c
Compare
No description provided.