feat: send RunPart metadata to upload endpoint
#57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
20 times, most recently
from
06848b2 to
9b963a3
Compare
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
9 times, most recently
from
dfdd096 to
4de349f
Compare
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
from
7490e74 to
702328e
Compare
Member
Author
|
@adriencaccia @Arthur I updated and also added some tests |
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
from
702328e to
ed81950
Compare
Member
Author
|
@art049 sorry about the force-pushes. Here is the comparison link between the reviewed and the latest version: https://github.com/CodSpeedHQ/runner/compare/f87e92ed46b24c5635282521365023e1a31571d5..ed81950a62afe82f0c8d2839fa940d46ea9bc5a3 |
adriencaccia
approved these changes
Jan 30, 2025
art049
reviewed
Jan 31, 2025
Member
art049
left a comment
art049
left a comment
There was a problem hiding this comment.
As discussed together, it would be best to just keep job-index and job-total in the last part of the matrix part id
art049
approved these changes
Jan 31, 2025
Member
Author
|
@adriencaccia I removed some values from the metadata, can you release a new beta version? |
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
3 times, most recently
from
58523ef to
f5f1005
Compare
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
from
f5f1005 to
2a75794
Compare
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
from
2a75794 to
c999e1d
Compare
adriencaccia
requested changes
Feb 14, 2025
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
from
c999e1d to
b694997
Compare
Member
Author
|
@adriencaccia updated |
art049
approved these changes
Feb 17, 2025
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
from
826032c to
b694997
Compare
fargito
deleted the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.