Skip to content

fix(gitlab): use correct ref for tag pipelines #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fargito merged 2 commits into from
Nov 28, 2024
Merged

fix(gitlab): use correct ref for tag pipelines #52

fargito merged 2 commits into from
Nov 28, 2024

Conversation

@fargito
Copy link
Member

@fargito fargito commented Nov 27, 2024

No description provided.

@fargito fargito requested a review from art049 November 27, 2024 15:54
@fargito fargito self-assigned this Nov 27, 2024
@fargito fargito requested a review from adriencaccia November 27, 2024 15:54
@fargito fargito force-pushed the fix/gitlab-tag-pipelines branch from eeb5eef to eeef6f5 Compare November 27, 2024 17:12
adriencaccia
adriencaccia approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@adriencaccia adriencaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on @art049

art049
art049 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@art049 art049 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to remove those beta commits though since it's changing the changelog and creates useless noise.

Will need to address this issue separately(not emitting the changelog on beta releases)

Also tests are failing

@fargito fargito force-pushed the fix/gitlab-tag-pipelines branch from eeef6f5 to 44e5470 Compare November 28, 2024 09:54
@fargito fargito merged commit 44e5470 into main Nov 28, 2024
9 checks passed
@fargito fargito deleted the fix/gitlab-tag-pipelines branch November 28, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@art049 art049 art049 approved these changes

@adriencaccia adriencaccia adriencaccia approved these changes

Assignees

@fargito fargito

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fargito @art049 @adriencaccia