Skip to content

fix: do not cat stdout from command to pipe.data #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuillaumeLagrange merged 1 commit into from
Jan 6, 2026
Merged

fix: do not cat stdout from command to pipe.data #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/executor/wall_time/perf/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,16 @@ impl PerfRunner {
// Output the perf data to the profile folder
let perf_data_file_path = self.get_perf_file_path(profile_folder);

let raw_command = format!(
"set -o pipefail && {} | cat > {}",
&cmd_builder.as_command_line(),
perf_data_file_path.to_string_lossy()
);
let raw_command = if self.output_pipedata {
format!(
"set -o pipefail && {} | cat > {}",
&cmd_builder.as_command_line(),
perf_data_file_path.to_string_lossy()
)
} else {
cmd_builder.as_command_line()
};

let mut wrapped_builder = CommandBuilder::new("bash");
wrapped_builder.args(["-c", &raw_command]);

Expand Down
Loading