Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uploader): handle error response when retrieving upload data #11

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

adriencaccia
Copy link
Member

@adriencaccia adriencaccia commented Dec 22, 2023

When there is a client error during the retrieval of the upload data, the error is obfuscated. This prevents users from seeing helpful error messages to debug the problem.

See https://github.com/unjs/magic-regexp/actions/runs/7280511804/job/19839080023?pr=363#step:6:73 as an example

This PR ensures that when a client error is detected, it is returned to the user.

For example, Failed to retrieve upload data: 401 Unauthorized {"error":"Repository not found (or the token is invalid)"}

@adriencaccia adriencaccia assigned art049 and unassigned art049 Dec 22, 2023
@adriencaccia adriencaccia merged commit c1e5b19 into main Dec 23, 2023
7 checks passed
@adriencaccia adriencaccia deleted the fix/upload-error-message branch December 23, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants