Skip to content

Conversation

@not-matthias
Copy link
Member

Doing this in a separate PR to check for regressions.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed Performance Report

Merging #88 will degrade performances by 11.71%

Comparing add-mode (0bd64af) with master (192d881)

Summary

⚡ 17 improvements
❌ 14 regressions
✅ 136 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
WallTime test_iir_filter_set_coefficients[a_coeffs0-b_coeffs0] 855.3 ns 890.8 ns -3.98%
WallTime test_combination_lists[4-2] 3.8 µs 3.9 µs -3.97%
WallTime test_combination_lists[5-4] 3.6 µs 3.4 µs +4.21%
WallTime test_combination_sum[candidates0-8] 11 µs 11.5 µs -5.15%
WallTime test_generate_all_combinations[0-0] 1.4 µs 1.3 µs +2.44%
WallTime test_generate_all_combinations[4-2] 7.1 µs 7.3 µs -2.91%
WallTime test_generate_all_subsequences[sequence0] 192.6 µs 197.5 µs -2.48%
WallTime test_generate_parenthesis[3] 10.4 µs 10.2 µs +2.15%
WallTime test_generate_sum_of_subsets_soln[nums0-9] 24.9 µs 23.1 µs +8.03%
WallTime test_get_valid_pos[pos0-4] 3 µs 2.8 µs +4.44%
WallTime test_is_complete[board0] 1.8 µs 1.6 µs +11.19%
WallTime test_is_safe[board0-1-1] 10.3 µs 10 µs +2.75%
WallTime test_sum_squares_slow 289.1 µs 297.2 µs -2.72%
WallTime test_iterative_fibo_10 1.4 µs 1.4 µs -2.02%
WallTime test_recursive_cached_fibo_10 8.3 µs 8.8 µs -5.8%
WallTime test_recursive_fibo_10 41.9 µs 43.9 µs -4.43%
WallTime test_recursive_fibo_20 4.8 ms 5.4 ms -11.71%
WallTime test_count_even[count_even_slow] 1.5 ms 1.4 ms +6.67%
WallTime test_sum_of_squares[sum_of_squares_sum_comprehension_power] 233.8 µs 221 µs +5.79%
WallTime test_sum_of_squares[sum_of_squares_sum_comprehension_product] 196.5 µs 190.8 µs +2.97%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@art049
Copy link
Member

art049 commented Oct 6, 2025

(added it already in my PR #75)

@art049 art049 closed this Oct 6, 2025
@not-matthias not-matthias deleted the add-mode branch October 22, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants