feat: init library #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COD-731 IPC implementation for perf and other tools
|
not-matthias
force-pushed
the
cod-731-ipc-implementation-for-perf-and-other-tools
branch
from
0c72ef2 to
7b77d4a
Compare
not-matthias
force-pushed
the
cod-731-ipc-implementation-for-perf-and-other-tools
branch
from
014cb22 to
3363c83
Compare
not-matthias
force-pushed
the
cod-731-ipc-implementation-for-perf-and-other-tools
branch
3 times, most recently
from
2b6d83e to
134bfcf
Compare
art049
requested changes
Apr 24, 2025
Member
art049
left a comment
art049
left a comment
There was a problem hiding this comment.
The zig code looks really good. The generated c part seems too large though and having less control on inlining and the exact behavior around the benchmark might be a big problem.
Naming note:
perf and valgrind should be named instruments or executors (which is a special type of instrument in our business lexicon) and not integrations. An integration is tied to a specific language/framework so it doesn't work here.
not-matthias
force-pushed
the
cod-731-ipc-implementation-for-perf-and-other-tools
branch
from
0da2414 to
7a0c6d2
Compare
not-matthias
force-pushed
the
cod-731-ipc-implementation-for-perf-and-other-tools
branch
from
7a0c6d2 to
daf082b
Compare
not-matthias
force-pushed
the
cod-731-ipc-implementation-for-perf-and-other-tools
branch
4 times, most recently
from
145ce11 to
60137a1
Compare
art049
approved these changes
May 13, 2025
not-matthias
force-pushed
the
cod-731-ipc-implementation-for-perf-and-other-tools
branch
from
dc6fec6 to
424ce29
Compare
not-matthias
deleted the
cod-731-ipc-implementation-for-perf-and-other-tools
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.