Skip to content

Cod 711 file name missing in codspeed rust flamegraph #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions crates/cargo-codspeed/src/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,15 @@ impl BuildOptions<'_> {
// Add debug info (equivalent to -g)
rust_flags.push_str(" -C debuginfo=2");

// Prevent debug info stripping
// https://doc.rust-lang.org/cargo/reference/profiles.html#release
// According to cargo docs, for release profile which we default to:
// `strip = "none"` and `debug = false`.
// In practice, if we set debug info through RUSTFLAGS, cargo still strips them, most
// likely because debug = false in the release profile.
// We also need to disable stripping through rust flags.
rust_flags.push_str(" -C strip=none");

// Add the codspeed cfg flag if instrumentation mode is enabled
if measurement_mode == MeasurementMode::Instrumentation {
rust_flags.push_str(" --cfg codspeed");
Expand Down
8 changes: 4 additions & 4 deletions crates/divan_compat/benches/basic_example.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use codspeed_divan_compat::Bencher;

fn fibo(n: i32) -> i32 {
fn fibo(n: u64) -> u64 {
let mut a = 0;
let mut b = 1;

Expand All @@ -14,12 +14,12 @@ fn fibo(n: i32) -> i32 {
}

#[codspeed_divan_compat::bench]
fn fibo_500() -> i32 {
codspeed_divan_compat::black_box(fibo(500))
fn fibo_50() -> u64 {
codspeed_divan_compat::black_box(fibo(50))
}

#[codspeed_divan_compat::bench]
fn fibo_10() -> i32 {
fn fibo_10() -> u64 {
codspeed_divan_compat::black_box(fibo(10))
}

Expand Down