Skip to content

chore: remove deprecated feature from cargo-codspeed release build #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
with:
bins: cross

- run: ${{ matrix.cross && 'cross' || 'cargo' }} build --locked --release --features vendored-openssl --bin cargo-codspeed --target ${{ matrix.target }}
- run: ${{ matrix.cross && 'cross' || 'cargo' }} build --locked --release --bin cargo-codspeed --target ${{ matrix.target }}

- name: Upload Release Asset
id: upload-release-asset
Expand Down
5 changes: 3 additions & 2 deletions crates/divan_compat/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,6 @@ Finished running 1 benchmark suite(s)

### Not supported:

- `divan::bench(const = xxx)`: we do not support this feature yet, if you need it don't hesitate to create an issue.
- `divan::bench(crate = xxx)`: due to how the compatibility layer works internally, we do not plan to support this feature.
- [`divan::bench(crate = xxx)`](https://docs.rs/divan/latest/divan/attr.bench.html#crate): due to how the compatibility layer works internally, we do not plan to support this feature.
- [`divan::bench(consts = xxx)`](https://docs.rs/divan/latest/divan/attr.bench.html#consts): we do not support this feature yet, if you need it don't hesitate to create an issue.
- [`divan::bench_group`](https://docs.rs/divan/latest/divan/attr.bench_group.html): we do not support benchmark grouping this feature yet, if you need it don't hesitate to create an issue.
3 changes: 1 addition & 2 deletions crates/divan_compat/examples/benches/math.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//! Copied from divan's exmaples
//! Copied from divan's examples
use divan::black_box;
use std::collections::{BTreeMap, HashMap};

Expand Down Expand Up @@ -63,7 +63,6 @@ mod fibonacci {
}
}

#[allow(dead_code)]
trait Map: Default {
fn get(&self, key: u64) -> Option<u64>;
fn set(&mut self, key: u64, value: u64);
Expand Down