Skip to content

chore: bump rust toolchain to 1.88.0 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Conversation

art049
Copy link
Member

@art049 art049 commented Jun 30, 2025

Summary

  • Bump Rust toolchain from 1.80.0 to 1.88.0
  • Fix all clippy warnings that arose from the new toolchain version
  • Update code to use inline format variables as required by clippy::uninlined-format-args

Changes

  • Updated rust-toolchain.toml to specify version 1.88.0
  • Fixed ~10 instances of format string warnings across multiple crates
  • Replaced std::ptr::fn_addr_eq with pointer casting to maintain MSRV compatibility

Test plan

  • All pre-commit hooks pass
  • cargo fmt --all runs successfully
  • cargo clippy --all-targets --all-features -- -D warnings passes

🤖 Generated with Claude Code

Copy link

codspeed-hq bot commented Jun 30, 2025

CodSpeed Instrumentation Performance Report

Merging #104 will degrade performances by 36.24%

Comparing fix-pre-commit-errors (96317b0) with main (d78ae4a)

Summary

⚡ 17 improvements
❌ 25 regressions
✅ 125 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
a 281.4 ns 310.6 ns -9.39%
a 281.4 ns 310.3 ns -9.31%
fibo_iterative 156.1 ns 126.9 ns +22.98%
sum_fold 283.9 ns 254.7 ns +11.45%
Iterative 103.6 ns 162.5 ns -36.24%
Iterative[20] 103.6 ns 162.5 ns -36.24%
Iterative[21] 105.3 ns 164.2 ns -35.87%
sleep_100ms 595.3 ns 624.4 ns -4.67%
sleep_10ms 566.1 ns 595.3 ns -4.9%
sleep_1ms 566.1 ns 595.3 ns -4.9%
sleep_50ms 566.1 ns 595.3 ns -4.9%
bench_array1[10] 254.2 ns 195.8 ns +29.79%
bench_array1[1] 119.2 ns 90 ns +32.41%
bench_array2[10] 254.2 ns 195.8 ns +29.79%
bench_array2[1] 119.2 ns 90 ns +32.41%
init_array[1000] 9.4 µs 9.1 µs +3.38%
fibo_50 90.3 ns 119.4 ns -24.42%
div 124.2 ns 95 ns +30.7%
recursive[0] 240.3 ns 211.1 ns +13.82%
recursive[5] 320.3 ns 291.1 ns +10.02%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link

codspeed-hq bot commented Jun 30, 2025

CodSpeed WallTime Performance Report

Merging #104 will degrade performances by 57.78%

Comparing fix-pre-commit-errors (474990b) with main (07d226e)

Summary

⚡ 27 improvements
❌ 22 regressions
✅ 105 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
Recursive 52.4 µs 50.4 µs +4.02%
Recursive[20] 52.3 µs 50.4 µs +3.95%
Recursive[21] 84.7 µs 81.5 µs +3.93%
fibonacci_custom_measurement 421 ns 380 ns +10.79%
large_drop 178.9 µs 170.3 µs +5.01%
large_setup 11 ns 13 ns -15.38%
from_elem[16384] 852 ns 818 ns +4.16%
from_elem[2048] 255 ns 232 ns +9.91%
from_elem[4096] 329 ns 317 ns +3.79%
init_array[1000] 1.8 µs 2.1 µs -14.46%
print_env_hello 1.9 µs 2.2 µs -11.67%
iterative[5] 7 ns 8 ns -12.5%
recursive[0] 2 ns 1 ns ×2
recursive_memoized[BTreeMap<u64, u64>, 0] 17 ns 14 ns +21.43%
recursive_memoized[BTreeMap<u64, u64>, 10] 516 ns 585 ns -11.79%
recursive_memoized[BTreeMap<u64, u64>, 20] 1.7 µs 1.9 µs -8.02%
recursive_memoized[BTreeMap<u64, u64>, 5] 182 ns 232 ns -21.55%
recursive_memoized[HashMap<u64, u64>, 0] 15 ns 16 ns -6.25%
recursive_memoized[HashMap<u64, u64>, 10] 1.5 µs 1.6 µs -3.19%
sort_unstable 130.5 µs 109.7 µs +18.95%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

- Fix clippy::uninlined-format-args warnings by using inline format variables
- Fix unpredictable-function-pointer-comparisons error by using pointer casting
- Update all format strings to use inline variable syntax

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@art049 art049 force-pushed the fix-pre-commit-errors branch from 474990b to 96317b0 Compare June 30, 2025 12:51
@adriencaccia adriencaccia merged commit 96317b0 into main Jun 30, 2025
12 of 13 checks passed
@adriencaccia adriencaccia deleted the fix-pre-commit-errors branch June 30, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants