Skip to content

Conversation

@not-matthias
Copy link
Member

No description provided.

@not-matthias not-matthias requested review from GuillaumeLagrange, adriencaccia and Copilot and removed request for Copilot November 27, 2025 09:56
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 27, 2025

CodSpeed Performance Report

Merging #41 will degrade performances by 97.31%

Comparing cod-1740-codspeed-go-invalid-minimum-benchmark-time-with-bloop (a6c2549) with main (0f118b3)

Summary

⚡ 3 improvements
❌ 1 regression
✅ 38 untouched
🆕 6 new

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
BenchmarkLargeSetupInLoop 261.8 µs 9,740 µs -97.31%
🆕 BenchmarkWithOutlierMeasurementModern N/A 1.1 ms N/A
🆕 BenchmarkWithOutlierMeasurementTraditional N/A 1.1 ms N/A
🆕 BenchmarkWithStopModern N/A 1.1 ms N/A
🆕 BenchmarkWithStopTraditional N/A 1.1 ms N/A
🆕 BenchmarkWithoutStartupModern N/A 1.1 ms N/A
🆕 BenchmarkWithoutStartupTraditional N/A < 1 ns N/A
bench_collect_results[10000000, 10] 2.6 s 2.3 s +11.63%
bench_collect_results[10000000, 5] 2.3 s 2 s +15.27%
bench_go_runner 36.1 s 26.4 s +36.82%

@not-matthias not-matthias force-pushed the cod-1740-codspeed-go-invalid-minimum-benchmark-time-with-bloop branch from 8a7a7b5 to e5a0c2c Compare November 27, 2025 10:42
@not-matthias not-matthias force-pushed the cod-1740-codspeed-go-invalid-minimum-benchmark-time-with-bloop branch 3 times, most recently from ec4ccc3 to bb05b24 Compare November 27, 2025 14:11
@not-matthias not-matthias force-pushed the cod-1740-codspeed-go-invalid-minimum-benchmark-time-with-bloop branch 2 times, most recently from d328bb0 to 37226bd Compare November 27, 2025 16:19
Copy link

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@not-matthias not-matthias force-pushed the cod-1740-codspeed-go-invalid-minimum-benchmark-time-with-bloop branch from 37226bd to a6c2549 Compare November 27, 2025 17:58
@not-matthias not-matthias merged commit a6c2549 into main Nov 27, 2025
15 of 16 checks passed
@not-matthias not-matthias deleted the cod-1740-codspeed-go-invalid-minimum-benchmark-time-with-bloop branch November 27, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants