Skip to content

Conversation

@not-matthias
Copy link
Member

Fixes #28

Changes in this PR:

  • Added quic-go as a test case
  • Bumped testing to 1.25
  • Removed the compat package, and automatically patch imports to point to the testing fork

@not-matthias not-matthias force-pushed the cod-1636-build-error-cannot-use-t-variable-of-type-codspeedt-as branch from 6566111 to 1a8abdd Compare November 5, 2025 17:59
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 5, 2025

CodSpeed Performance Report

Merging #29 will degrade performances by 23.26%

Comparing cod-1636-build-error-cannot-use-t-variable-of-type-codspeedt-as (bd7a35b) with main (9532997)

Summary

❌ 1 regression
✅ 23 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
BenchmarkLargeSetupInLoop 33 ns 43 ns -23.26%

@not-matthias not-matthias requested a review from art049 November 6, 2025 13:31
Copy link

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments, olgtm

@not-matthias not-matthias force-pushed the cod-1636-build-error-cannot-use-t-variable-of-type-codspeedt-as branch 2 times, most recently from 283b29f to 50303c0 Compare November 6, 2025 18:01
@not-matthias not-matthias force-pushed the cod-1636-build-error-cannot-use-t-variable-of-type-codspeedt-as branch from 50303c0 to c414ca0 Compare November 6, 2025 18:04
Copy link

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@not-matthias not-matthias force-pushed the cod-1636-build-error-cannot-use-t-variable-of-type-codspeedt-as branch 3 times, most recently from 27efc15 to c6bf592 Compare November 6, 2025 18:12
@not-matthias not-matthias force-pushed the cod-1636-build-error-cannot-use-t-variable-of-type-codspeedt-as branch from c6bf592 to bd7a35b Compare November 6, 2025 18:16
@not-matthias not-matthias merged commit bd7a35b into main Nov 7, 2025
14 of 15 checks passed
@not-matthias not-matthias deleted the cod-1636-build-error-cannot-use-t-variable-of-type-codspeedt-as branch November 7, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build error: cannot use t (variable of type *codspeed.T) as *testing.T value

3 participants