Skip to content

Conversation

@not-matthias
Copy link
Member

No description provided.

@not-matthias not-matthias requested review from art049 and Copilot and removed request for art049 October 13, 2025 13:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the instrument-hooks dependency to a newer commit version, changing the return type of several API functions from signed int8_t to unsigned uint8_t.

  • Updated the instrument-hooks commit hash in the vendor script
  • Modified API function signatures to use uint8_t instead of int8_t for return types
  • Changed callgrind functions from returning int8_t to void

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
testing/capi/vendor.sh Updates the commit hash for the instrument-hooks dependency
testing/capi/instrument-hooks/includes/core.h Updates function signatures to use uint8_t return types and void for callgrind functions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@not-matthias not-matthias force-pushed the cod-1498-codspeed-go-bump-instrument-hooks branch from 4393f58 to b3ff3d7 Compare October 14, 2025 08:43
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 14, 2025

CodSpeed Performance Report

Merging #20 will improve performances by 28%

Comparing cod-1498-codspeed-go-bump-instrument-hooks (b3ff3d7) with main (6024d5a)

Summary

⚡ 1 improvement
✅ 23 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
BenchmarkLargeSetupInLoop 32 ns 25 ns +28%

@not-matthias not-matthias merged commit b3ff3d7 into main Oct 14, 2025
13 checks passed
@not-matthias not-matthias deleted the cod-1498-codspeed-go-bump-instrument-hooks branch October 14, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants