Skip to content

Probably wrong vendoring #24

@hotrush

Description

@hotrush

In CI dependencies usually installed with go mod vendor. But seems your runner installs some own package with go get ... which makes vendor dir inconsistent with go.mod.

So, after installing the package you might want to run go mod vendor to fix inconsistencies, but it might not work if there are some private packages for example. Also you might want to ignore this inconsistency with adding -mod=readonly or -mod=mod to the go build command.

Maybe it makes more sense to use go install instead of go get + go build

TBH can't say for sure which way is better, it depends probably...

  Running as unit: run-r100a99c52fe64b27a5f51ad3f1718942.scope; invocation ID: 92323e76f03c42b3865ec396b0e2e7c1
  [INFO  codspeed_go_runner] Discovered 1 packages
  [INFO  codspeed_go_runner] Total benchmarks discovered: 1
  [INFO  codspeed_go_runner] Found BenchmarkPlugin_ItemsEndpoint  in "plugin_bench_test.go"
  [INFO  codspeed_go_runner] Generating custom runner for package: roadrunner
  [INFO  codspeed_go_runner] Building binary for package: roadrunner
  [WARN  codspeed_go_runner::builder] Build command output: 
  [WARN  codspeed_go_runner::builder] Build command error output: go: inconsistent vendoring in /tmp/.tmpov91hZ:
      	github.com/CodSpeedHQ/codspeed-go@v0.4.1: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
      
      	To ignore the vendor directory, use -mod=readonly or -mod=mod.
      	To sync the vendor directory, run:
      		go mod vendor
      
  [ERROR codspeed_go_runner] Failed to build roadrunner: Failed to build benchmark binary. Exit status: exit status: 1
  [INFO  codspeed_go_runner] Parsed 0 raw results

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions