Conversation
feat: 이벤트 날짜/시간 응답 포맷을 한글로 변경
fix: 이벤트 응답 DTO에 Campus 값 누락 문제
fix: 이벤트가 시작되면 validationEvent가 항상 false인 문제
feat: 유저 티켓팅 정보 검증 조건에 name이 null이거나 길이가 2 이하일 경우 false 추가
feat: 티켓팅 엑셀 내보내기에서 상품 수령을 완료한 유저만 포함되도록 조건 추가
- EventService를 EventQueryService와 EventCommandService로 분리했습니다. - EventStockProducerService, StockCheckJob에서 불필요한 주석, 내용을 삭제했습니다. - TicketingErrorCode에 PAGE_ILLEGAL_ARGUMENT 에러를 추가했습니다.
관리 되지 않았던 테스트 코드들을 현재 비즈니스 로직에 맞게 수정했습니다. 또한, 분할 된 EventService에 맞게 EventServiceTest를 EventQueryServiceTest와 EventCommandServiceTest로 분할했습니다.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)
develop 브랜치를 merge해와서 진행했는데, 지금 변경사항을 follow-up 못해서 테스트와 로직 간의 이상이 있다면 알려주세요.