Fix validation errors #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Leftover warning should only be |
Contributor
Author
|
Too fast Zach, hoped that @Psithief has an idea about the other error. :P (Version bump was also missing) |
Contributor
|
Those fixes are fine but why did the |
tooomm
commented
Oct 18, 2020
| <pt>2/2</pt> | ||
| </prop> | ||
| <set picURL="https://media.wizards.com/2019/mh1/en_tM8ljjBCro.png">MH1</set> | ||
| <token>1</token> |
Contributor
Author
There was a problem hiding this comment.
Those fixes are fine but why did the field change lines?
Because the linter complained:
https://travis-ci.com/github/Cockatrice/Magic-Token/builds/189491625#L188
I figured that the order is always like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted in #93