-
Notifications
You must be signed in to change notification settings - Fork 16
set xsi to http instead of https #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tooomm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice way with the lycheeignore file. 👍
Alternative would be to add --exclude www.w3.org or similar to the args.
|
this was the way to exclude urls listed in the action's readme, if you prefer the arg that'd also be fine, it'd keep the workflow confined to its own file instead of cluttering the repo. |
|
Probably there won't be any other links added there, right? |
f9d5a28 to
78e38b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the continue-on-error behaves different than you think and it's not helpful here:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error
We only have a single job that is run (check_urls)...
But just saw that you wanted to get rid of the if: always() that way.
Even putting it on the step level would only make the workflow pass, but still skip following steps I think. Meaning if the check on tokens.xml fails, challenge_tokens.xml is never checked. It's probably ok, to only put it on the second check - just for consistency I put it to both.
Or did you test this?
|
hmm, I might have misinterpreted the docs then, why don't we have one step checking both files? this would marginally improve speed too. |
|
👍 |
tooomm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to combine the two checks in one run!
Now the env is less useful, but it still makes it a bit more readable I think.
fixes #202