Skip to content

Conversation

@ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Mar 11, 2023

fixes #202

tooomm
tooomm previously approved these changes Mar 11, 2023
Copy link
Contributor

@tooomm tooomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice way with the lycheeignore file. 👍

Alternative would be to add --exclude www.w3.org or similar to the args.

@ebbit1q
Copy link
Member Author

ebbit1q commented Mar 11, 2023

this was the way to exclude urls listed in the action's readme, if you prefer the arg that'd also be fine, it'd keep the workflow confined to its own file instead of cluttering the repo.

@tooomm
Copy link
Contributor

tooomm commented Mar 12, 2023

Probably there won't be any other links added there, right?
In that case --exclude seems cleaner.

@tooomm tooomm dismissed their stale review March 12, 2023 12:04

Potential rework of excluding URLs pending

@ebbit1q ebbit1q requested a review from tooomm March 12, 2023 17:29
Copy link
Contributor

@tooomm tooomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the continue-on-error behaves different than you think and it's not helpful here:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error

We only have a single job that is run (check_urls)...

But just saw that you wanted to get rid of the if: always() that way.
Even putting it on the step level would only make the workflow pass, but still skip following steps I think. Meaning if the check on tokens.xml fails, challenge_tokens.xml is never checked. It's probably ok, to only put it on the second check - just for consistency I put it to both.
Or did you test this?

@ebbit1q
Copy link
Member Author

ebbit1q commented Mar 12, 2023

hmm, I might have misinterpreted the docs then, why don't we have one step checking both files? this would marginally improve speed too.

@ebbit1q
Copy link
Member Author

ebbit1q commented Mar 13, 2023

👍

Copy link
Contributor

@tooomm tooomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to combine the two checks in one run!

Now the env is less useful, but it still makes it a bit more readable I think.

@ebbit1q ebbit1q merged commit 7dafd41 into master Mar 13, 2023
@ebbit1q ebbit1q deleted the ebbit1q-patch-1 branch March 13, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tokens.xml fails to validate

2 participants