Update Token Links to Use API calls #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Changes made automatically in Python and requests adhere to the Scryfall /cards/:id endpoint format.
Contributor
Author
|
Should I close this in favor of #209? |
Member
|
I think so, it seems like the easier solution |
Contributor
Author
|
OK, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201 and should future proof the file against further link change.
API requests adheres to Scryfall's /cards/:id endpoint format. Image size defaults to large and face defaults to front so only format=image and the occasional face=back need to be specified.
I have checked that this file works in Cockatrice (at least for as many tokens as I could stand to look at) but its a huge number of changes so its not impossible that something somewhere broke. I also specifically checked all the back sides had well-formed requests since they required extra bits stuck on the end.