Skip to content

Conversation

@SlightlyCircuitous
Copy link
Contributor

While I was looking through the token xml, I found a few things that should probably be changed.

Not included in the pull is the fact that there's a card called 'Obosh, With The Leggies' listed as Reverse Related in the Companion Section. Is that supposed to be there or is it redundant with 'Obosh, the Preypiercer'?

SlightlyCircuitous and others added 2 commits June 15, 2022 11:54
*Move MH2 Construct Token to the 0/0 Construct card block as that one is a 0/0 not a 6/12
--Link is now a scryfall large as per Cockatrice#149

*Changed two 'The' to 'the'  to be in line with Oracle text (Tuktuk the Returned and Negan, the Cold-Blooded)
Copy link
Member

@ebbit1q ebbit1q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find, thanks!

@ebbit1q ebbit1q merged commit 18c28f8 into Cockatrice:master Jun 15, 2022
@ebbit1q
Copy link
Member

ebbit1q commented Jun 15, 2022

I assume obosh with the leggies might have been a preview card that had an incomplete name, scryfall adds these cards with funny names sometimes

@ebbit1q
Copy link
Member

ebbit1q commented Jun 15, 2022

doing a search of these shows we have a couple similar names:

"Big Boy Forest Crusher" placeholder for Quartzwood Crasher
"Destoroyah, Perfect Lifeform" alt name for Everquill Phoenix
"What's Kraken" placeholder for Ominous Seas
"Obosh, With The Leggies" placeholder for Obosh, the Preypiercer
"Gigan, Cyberclaw Terror" alt name for Gyruda, Doom of Depths

none of these names show up in the xml generated by oracle, they take their primary name and their alt name is ignored, in most cases being overwritten

I propose all of these be removed

@SlightlyCircuitous SlightlyCircuitous deleted the patch-1 branch June 16, 2022 03:37
@tooomm tooomm mentioned this pull request Jun 16, 2022
@tooomm
Copy link
Contributor

tooomm commented Jun 16, 2022

@SlightlyCircuitous Thanks for upgrading to the way better Scryfall image as well! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants