Skip to content

Conversation

@gq1
Copy link
Collaborator

@gq1 gq1 commented Feb 5, 2025

No description provided.

@gq1
Copy link
Collaborator Author

gq1 commented Feb 6, 2025

I moved the PR https://github.com/sanger-tol/tol-workflows/pull/2 to here.
@mcshane This is the new image being built by the pipeline along with this repo:
https://github.com/CobiontID/MarkerScan/pkgs/container/markerscan
Can you have a test? Thanks.

Originally I have this PR as well with minimal changes: https://github.com/sanger-tol/tol-workflows/pull/1

@gq1 gq1 requested review from mcshane and muffato February 6, 2025 09:28
@gq1 gq1 closed this Feb 6, 2025
@gq1 gq1 reopened this Feb 6, 2025
@muffato
Copy link
Member

muffato commented Feb 6, 2025

Can you explain how the tag of the image is decided ? Especially, can we make a git tag / github release and have the Docker image named the same way ?

@gq1
Copy link
Collaborator Author

gq1 commented Feb 6, 2025

Can you explain how the tag of the image is decided ?
For a PR, the image will be tagged as pr-1 etc, from the source branch.
For push to the main branch, will will be tag as main.

Many events can be added.

Especially, can we make a git tag / github release and have the Docker image named the same way ?
If you tag it with v1.1.1, the image will be tagged as 1.1.1, no matter release or not. At the same time the latest image tag will be pushed.
Other tags not prefixed with v will not trigger the image building.

@gq1 gq1 merged commit 4abf6ff into main Feb 6, 2025
2 checks passed
@gq1
Copy link
Collaborator Author

gq1 commented Feb 6, 2025

@mcshane I did a release 1.1.0 with all the changes, you can pull the following image to test:
ghcr.io/cobiontid/markerscan:1.1.0

@muffato muffato deleted the conda branch October 30, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants