Change logic to improve performance#5
Closed
ardavank wants to merge 1 commit into
Closed
Conversation
Thanks for the great tool! I was using this tool and I noticed that it works great for small unitypackages but it's extremely slow for larger ones. I improved the performance and wanted to share so that everyone can benefit from it Results comparison: (using: MacBook Pro - 2.4 GHz 8-Core Intel Core i9) ~ 7 MB unitypackage file: Before: 6.31 seconds After: 0.62 seconds ~ 5.52 GB unitypackage file: Before: I left it running for more than 15 hours and it never finished, had to cancel After: 71.8 seconds
Owner
|
Hmm, I guess it has to dig through the tar's entry table every time it does a My only concern with this PR is that if something goes wrong, the temp stuff is not deleted. Itd be preferable if we could use Python's # create a temporary directory using the context manager
>>> with tempfile.TemporaryDirectory() as tmpdirname:
... print('created temporary directory', tmpdirname)
>>>
# directory and contents have been removed |
Author
|
I agree, my code might not be production ready, I just wanted to share this with you. feel free to modify and improve it. |
Owner
|
Closing this, updates are in #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great tool!
I was using this tool and I noticed that it works great for small unitypackages but it's extremely slow for larger ones.
I improved the performance and wanted to share so that everyone can benefit from it
Results comparison: (using: MacBook Pro - 2.4 GHz 8-Core Intel Core i9)
~ 7 MB unitypackage file:
Before: 6.31 seconds
After: 0.62 seconds
~ 5.52 GB unitypackage file:
Before: I left it running for more than 15 hours and it never finished, had to cancel
After: 71.8 seconds